Bug 175900

Summary: [MSE] Don't increase the reported totalFrameDelay for non-displayed frames (or frames coming in while paused).
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jer Noble
Reported 2017-08-23 12:50:25 PDT
[MSE] Don't increase the reported totalFrameDelay for non-displayed frames (or frames coming in while paused).
Attachments
Patch (2.49 KB, patch)
2017-08-23 12:59 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (2.58 KB, patch)
2017-08-23 16:34 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.16 KB, patch)
2017-09-08 12:20 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-08-23 12:59:57 PDT
Created attachment 318905 [details] Patch
Radar WebKit Bug Importer
Comment 2 2017-08-23 13:28:52 PDT
<rdar://problem/34042444>
Jer Noble
Comment 3 2017-08-23 16:34:43 PDT
Created attachment 318938 [details] Patch
Eric Carlson
Comment 4 2017-08-24 08:18:12 PDT
Comment on attachment 318938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318938&action=review > Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:285 > + auto currentRate = CMTimebaseGetRate(m_timebase.get()); Looks like this needs to be soft linked.
Jer Noble
Comment 5 2017-09-08 12:20:20 PDT
Created attachment 320286 [details] Patch for landing
WebKit Commit Bot
Comment 6 2017-09-08 13:00:32 PDT
Comment on attachment 320286 [details] Patch for landing Rejecting attachment 320286 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 320286, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/4489883
WebKit Commit Bot
Comment 7 2017-09-12 13:15:01 PDT
Comment on attachment 320286 [details] Patch for landing Clearing flags on attachment: 320286 Committed r221937: <http://trac.webkit.org/changeset/221937>
WebKit Commit Bot
Comment 8 2017-09-12 13:15:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.