Bug 175868

Summary: Web Inspector: Make lock icon crispier
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, buildbot, commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Lock icon at x1
none
[Image] Current/proposed
none
Patch
none
[Image] Before/after at x1 and x2
none
Patch none

Nikita Vasilyev
Reported 2017-08-22 18:31:51 PDT
Created attachment 318842 [details] [Image] Lock icon at x1 The lock icon that is used in the Styles sidebar looks a bit blurry, especially on a non-retina (x1) screen. Pixel hinting could be improved.
Attachments
[Image] Lock icon at x1 (10.76 KB, image/png)
2017-08-22 18:31 PDT, Nikita Vasilyev 		no flags
Details
[Image] Current/proposed (27.50 KB, image/png)
2017-08-22 18:33 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.85 KB, patch)
2017-08-22 21:56 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Image] Before/after at x1 and x2 (2.30 KB, image/png)
2017-08-22 21:56 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.80 KB, patch)
2017-08-23 11:06 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2017-08-22 18:33:33 PDT
Created attachment 318843 [details] [Image] Current/proposed (will post a patch later tonight)
Nikita Vasilyev
Comment 2 2017-08-22 21:56:09 PDT
Created attachment 318852 [details] Patch
Nikita Vasilyev
Comment 3 2017-08-22 21:56:45 PDT
Created attachment 318853 [details] [Image] Before/after at x1 and x2
Matt Baker
Comment 4 2017-08-23 08:24:27 PDT
Comment on attachment 318852 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318852&action=review Looks crisper! r=me, with some cleanup. > Source/WebInspectorUI/UserInterface/Images/Locked.svg:4 > + <polygon fill="hsla(0, 0%, 0%, 0.5)" fill-rule="evenodd" stroke="none" points="0 5 8 5 8 10 0 10"/> fill-rule="evenodd" isn't needed. > Source/WebInspectorUI/UserInterface/Images/Locked.svg:5 > + <path stroke="hsla(0, 0%, 0%, 0.5)" stroke-width="1" fill="none" d="M 1.5 5 L 1.5 3 C 1.5 1.33333333 2.33333333 0.5 4 0.5 C 5.66666667 0.5 6.5 1.33333333 6.5 3 L 6.5 5"/> stroke-width="1" is the default, and can be removed.
Nikita Vasilyev
Comment 5 2017-08-23 11:06:28 PDT
Created attachment 318889 [details] Patch
WebKit Commit Bot
Comment 6 2017-08-23 11:47:37 PDT
Comment on attachment 318889 [details] Patch Clearing flags on attachment: 318889 Committed r221090: <http://trac.webkit.org/changeset/221090>
WebKit Commit Bot
Comment 7 2017-08-23 11:47:39 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-08-23 11:48:14 PDT
<rdar://problem/34040145>
Note You need to log in before you can comment on or make changes to this bug.