| Summary: | Opt all Mac clients into document-level media user gesture quirks | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Rajca <mrajca> | ||||||||||||||||
| Component: | Media | Assignee: | Matt Rajca <mrajca> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | buildbot, eric.carlson, jer.noble, rniwa | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Matt Rajca
2017-08-22 10:47:27 PDT
Created attachment 318765 [details]
Patch
Not to be reviewed. Comment on attachment 318765 [details] Patch Attachment 318765 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4362089 New failing tests: http/tests/media/autoplay-if-audio-is-playing.html Created attachment 318777 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 318765 [details] Patch Attachment 318765 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4362270 New failing tests: http/tests/media/autoplay-if-audio-is-playing.html Created attachment 318778 [details]
Archive of layout-test-results from ews100 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 318765 [details] Patch Attachment 318765 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4362276 New failing tests: http/tests/media/autoplay-if-audio-is-playing.html Created attachment 318779 [details]
Archive of layout-test-results from ews117 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 318790 [details]
Patch
Comment on attachment 318790 [details] Patch Attachment 318790 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4364207 New failing tests: media/track/track-element-load-event.html Created attachment 318821 [details]
Archive of layout-test-results from ews116 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
(In reply to Build Bot from comment #12) > Created attachment 318821 [details] > Archive of layout-test-results from ews116 for mac-elcapitan > > The attached test failures were seen while running run-webkit-tests on the > mac-debug-ews. > Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6 The Mac debug failure looks like an unrelated assertion failure in updating text track displays: ASSERT(m_mediaControlsHost); Created attachment 318873 [details]
Patch
(In reply to Matt Rajca from comment #13) > (In reply to Build Bot from comment #12) > > Created attachment 318821 [details] > > Archive of layout-test-results from ews116 for mac-elcapitan > > > > The attached test failures were seen while running run-webkit-tests on the > > mac-debug-ews. > > Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6 > > The Mac debug failure looks like an unrelated assertion failure in updating > text track displays: ASSERT(m_mediaControlsHost); Re-running EWS fixed it. Comment on attachment 318873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318873&action=review > Source/WebCore/ChangeLog:3 > + Opt all Mac clients into document-level media user gesture quirks. "all Mac clients" is not accurate, can't any host app set needsSiteSpecificQuirks to true? (In reply to Eric Carlson from comment #16) > Comment on attachment 318873 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318873&action=review > > > Source/WebCore/ChangeLog:3 > > + Opt all Mac clients into document-level media user gesture quirks. > > "all Mac clients" is not accurate, can't any host app set > needsSiteSpecificQuirks to true? This quirk is under #if PLATFORM(MAC) so it doesn't affect iOS. Comment on attachment 318873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318873&action=review >>> Source/WebCore/ChangeLog:3 >>> + Opt all Mac clients into document-level media user gesture quirks. >> >> "all Mac clients" is not accurate, can't any host app set needsSiteSpecificQuirks to true? > > This quirk is under #if PLATFORM(MAC) so it doesn't affect iOS. Yes, but won't this change the behavior of a WebKit app on a non-macOS platform that calls settings.setNeedsSiteSpecificQuirks(true)? (In reply to Eric Carlson from comment #18) > Comment on attachment 318873 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318873&action=review > > >>> Source/WebCore/ChangeLog:3 > >>> + Opt all Mac clients into document-level media user gesture quirks. > >> > >> "all Mac clients" is not accurate, can't any host app set needsSiteSpecificQuirks to true? > > > > This quirk is under #if PLATFORM(MAC) so it doesn't affect iOS. > > Yes, but won't this change the behavior of a WebKit app on a non-macOS > platform that calls settings.setNeedsSiteSpecificQuirks(true)? No. It only applies to Mac clients that opt-into quirks. Do we want it to run on non-macOS platforms as well? Committed r221386: <http://trac.webkit.org/changeset/221386> |