Bug 175816 – Speedometer 2.0: Add button to select and unselect all tests to InteractiveRunner.html

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Ryosuke Niwa]

Now that we have doubled the number of test cases in Speedometer,
we should have buttons to quickly select & unselect all test cases.

[Ryosuke Niwa]

Created attachment 318745 [details]
Adds the buttons

[Ryosuke Niwa]

Created attachment 318746 [details]
Removed superfluous newline

[Saam Barati]

Comment on attachment 318746 [details]
Removed superfluous newline

View in context: https://bugs.webkit.org/attachment.cgi?id=318746&action=review

r=me

> PerformanceTests/Speedometer/InteractiveRunner.html:77
> +        for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) {

For of?

> PerformanceTests/Speedometer/InteractiveRunner.html:87
> +        for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) {

Ditto

[Ryosuke Niwa]

(In reply to Saam Barati from comment #3)
> Comment on attachment 318746 [details]
> Removed superfluous newline
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318746&action=review
> 
> r=me
> 
> > PerformanceTests/Speedometer/InteractiveRunner.html:77
> > +        for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) {
> 
> For of?

No, we don't want the runner code to require ES2015. We occasionally run the latest version of Speedometer in very old versions of Safari for validation purposes. See https://bugs.webkit.org/show_bug.cgi?id=172439 for example in which I ran trunk Speedometer on Safari 7.

>
> > PerformanceTests/Speedometer/InteractiveRunner.html:87
> > +        for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) {
> 
> Ditto

Ditto.

[Ryosuke Niwa]

Committed r221039: <http://trac.webkit.org/changeset/221039>

[Radar WebKit Bug Importer]

<rdar://problem/34020295>