Summary: | Cleanup TextPainter | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | buildbot, mmaxfield, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Local Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Daniel Bates
2017-08-21 14:13:19 PDT
Created attachment 318671 [details]
Patch
Attachment 318671 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/TextPainter.cpp:36: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 318671 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318671&action=review > Source/WebCore/rendering/TextPainter.cpp:4 > + * Copyright (C) 2004-2017 Apple Inc. All rights reserved. Are we actually allowed to retroactively add in 2014-2016? > Source/WebCore/rendering/TextPainter.cpp:40 > + : m_context { context } > + , m_shadow { shadow } > + , m_onlyDrawsShadow { !isLastShadowIteration() || !lastShadowIterationShouldDrawText } > + , m_avoidDrawingShadow { shadowIsCompletelyCoveredByText(opaque) } > + , m_nothingToDraw { shadow && m_avoidDrawingShadow && m_onlyDrawsShadow } > + , m_didSaveContext { false } What's the reason for this change? I haven't seen this style in any other code. Comment on attachment 318671 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318671&action=review >> Source/WebCore/rendering/TextPainter.cpp:4 >> + * Copyright (C) 2004-2017 Apple Inc. All rights reserved. > > Are we actually allowed to retroactively add in 2014-2016? Yes, Apple employees made changes throughout 2014-2016. >> Source/WebCore/rendering/TextPainter.cpp:40 >> + , m_didSaveContext { false } > > What's the reason for this change? I haven't seen this style in any other code. We should bring this up on webkit-dev to standardize. I have seen a movement towards using this style. See bug #173682, comment #4. Committed r220988: <http://trac.webkit.org/changeset/220988> |