Bug 175765

Summary:

Remove support for >> descendant combinator syntax

Product:

WebKit

Reporter:

Aryeh Gregor <ayg>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, commit-queue, emilio, hyatt, koivisto, sam, simon.fraser, webkit-bug-importer, webkit.bugzilla, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	none
patch	none

Aryeh Gregor

Reported 2017-08-21 03:57:50 PDT

There are some wpt tests for the ">>" descendant selector, but I would like to remove them: https://github.com/w3c/web-platform-tests/pull/6785 Because no one implements this feature other than WebKit, and it's not clear we want to keep it in the spec: https://github.com/w3c/csswg-drafts/issues/641 This is just a heads-up so you can decide if you want to 1) copy the tests somewhere so you maintain test coverage for this feature, 2) not care about not having test coverage, 3) get rid of the feature.

Attachments
patch (133.69 KB, patch) 2017-09-08 06:37 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (172.01 KB, patch) 2017-09-08 07:32 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (285.09 KB, patch) 2017-09-08 08:19 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2017-08-21 11:35:21 PDT

This was https://bugs.webkit.org/show_bug.cgi?id=140525 Considering no one else implemented this and that the feature is rather obscure it is probably pretty safe to just remove it.

Antti Koivisto

Comment 2 2017-09-08 06:37:26 PDT

Created attachment 320259 [details] patch

Antti Koivisto

Comment 3 2017-09-08 07:32:36 PDT

Created attachment 320262 [details] patch

Antti Koivisto

Comment 4 2017-09-08 08:19:01 PDT

Created attachment 320265 [details] patch

Sam Weinig

Comment 5 2017-09-08 08:43:42 PDT

Comment on attachment 320265 [details] patch rs=me Probably about time to get rid of the CSS_SELECTORS_LEVEL4 platform define as well.