Bug 175765

Summary: Remove support for >> descendant combinator syntax
Product: WebKit Reporter: Aryeh Gregor <ayg>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, commit-queue, emilio, hyatt, koivisto, sam, simon.fraser, webkit-bug-importer, webkit.bugzilla, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch none

Description Aryeh Gregor 2017-08-21 03:57:50 PDT 
There are some wpt tests for the ">>" descendant selector, but I would like to remove them:

https://github.com/w3c/web-platform-tests/pull/6785

Because no one implements this feature other than WebKit, and it's not clear we want to keep it in the spec:

https://github.com/w3c/csswg-drafts/issues/641

This is just a heads-up so you can decide if you want to 1) copy the tests somewhere so you maintain test coverage for this feature, 2) not care about not having test coverage, 3) get rid of the feature.
Comment 1 Antti Koivisto 2017-08-21 11:35:21 PDT 
This was https://bugs.webkit.org/show_bug.cgi?id=140525

Considering no one else implemented this and that the feature is rather obscure it is probably pretty safe to just remove it.
Comment 2 Antti Koivisto 2017-09-08 06:37:26 PDT 
Created attachment 320259 [details]
patch
Comment 3 Antti Koivisto 2017-09-08 07:32:36 PDT 
Created attachment 320262 [details]
patch
Comment 4 Antti Koivisto 2017-09-08 08:19:01 PDT 
Created attachment 320265 [details]
patch
Comment 5 Sam Weinig 2017-09-08 08:43:42 PDT 
Comment on attachment 320265 [details]
patch

rs=me

Probably about time to get rid of the CSS_SELECTORS_LEVEL4 platform define as well.
Comment 6 Antti Koivisto 2017-09-08 09:03:20 PDT 
It has some other stuff too but it is true that we probably don't need CSS_SELECTORS_LEVEL4.
Comment 7 WebKit Commit Bot 2017-09-08 09:35:49 PDT 
Comment on attachment 320265 [details]
patch

Clearing flags on attachment: 320265

Committed r221788: <http://trac.webkit.org/changeset/221788>
Comment 8 WebKit Commit Bot 2017-09-08 09:35:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-09-08 09:37:28 PDT 
<rdar://problem/34332407>