Bug 175752

Summary: Factor :before/:after render tree mutations into a RenderTreeUpdater helper class
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cgarcia, commit-queue, kling, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
kling: review+
patch none

Antti Koivisto
Reported 2017-08-19 10:28:34 PDT
Move render tree mutation code out from PseudoElement.
Attachments
patch (27.25 KB, patch)
2017-08-19 10:36 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
patch (27.73 KB, patch)
2017-08-20 01:59 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-08-19 10:36:31 PDT
Created attachment 318586 [details] patch
Andreas Kling
Comment 2 2017-08-19 14:00:04 PDT
Comment on attachment 318586 [details] patch r=me Thought: Maybe RenderTreeUpdater could have a RenderView& getter?
Antti Koivisto
Comment 3 2017-08-20 01:59:38 PDT
Created attachment 318598 [details] patch
WebKit Commit Bot
Comment 4 2017-08-20 02:42:12 PDT
Comment on attachment 318598 [details] patch Clearing flags on attachment: 318598 Committed r220956: <http://trac.webkit.org/changeset/220956>
WebKit Commit Bot
Comment 5 2017-08-20 02:42:14 PDT
All reviewed patches have been landed. Closing bug.
Carlos Garcia Campos
Comment 6 2017-08-28 05:23:17 PDT
Comment on attachment 318598 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=318598&action=review > Source/WebCore/style/RenderTreeUpdater.cpp:350 > - FlowThreadController& flowThreadController = element.document().renderView()->flowThreadController(); > + FlowThreadController& flowThreadController = renderView().flowThreadController(); This doesn't build (with CSS regions enabled), because this is a static function, so there's not this to call renderView().
Radar WebKit Bug Importer
Comment 7 2017-08-28 05:27:28 PDT
<rdar://problem/34108878>
Note You need to log in before you can comment on or make changes to this bug.