Bug 175729

Summary: [Repaint Outside Layout] Add a pref for repainting outside of layout
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, dbates, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+

Dave Hyatt
Reported 2017-08-18 11:28:19 PDT
Add a pref for repainting outside of layout.
Attachments
Patch (1.86 KB, patch)
2017-08-18 11:29 PDT, Dave Hyatt 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2017-08-18 11:29:15 PDT
Created attachment 318523 [details] Patch
Daniel Bates
Comment 2 2017-08-18 12:00:51 PDT
Comment on attachment 318523 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318523&action=review > Source/WebCore/rendering/RenderElement.cpp:2191 > + if (document().view()->needsFullRepaint() || !everHadLayout() || hasSelfPaintingLayer()) > + return false; > + return !settings().repaintOutsideLayoutEnabled(); I take it you feel this reads better. I would have written this using one line without a branch: return !document().view()->needsFullRepaint() && everHadLayout() && !hasSelfPaintingLayer() && !settings().repaintOutsideLayoutEnabled();
Dave Hyatt
Comment 3 2017-08-24 10:53:52 PDT
Landed in r221147.
Note You need to log in before you can comment on or make changes to this bug.