Summary: | Rename DataTransferAccessPolicy to match spec and refactor related node | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, webkit-bug-importer, wenson_hsieh | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2017-08-17 20:04:44 PDT
Created attachment 318462 [details]
Cleanup
Created attachment 318463 [details]
Fixed iOS builds
Comment on attachment 318463 [details] Fixed iOS builds View in context: https://bugs.webkit.org/attachment.cgi?id=318463&action=review > Source/WebCore/editing/Editor.cpp:331 > + storeMode = DataTransfer::StoreMode::Invalid; Possibly helpful to ASSERT() that eventType is one of the other clipboard event types here, that is not handled above? > Source/WebCore/editing/Editor.cpp:346 > + pasteboard->writePasteboard(dataTransfer->pasteboard()); This reminds me -- we'll need to actually implement a lot of these methods on iOS. Pasteboard::writePasteboard, for example, is stubbed out in PasteboardIOS.mm > Source/WebCore/page/DragController.cpp:233 > + DragOperation srcOpMask = dragData.draggingSourceOperationMask(); I don't think this temporary variable adds much clarity. (In reply to Wenson Hsieh from comment #3) > Comment on attachment 318463 [details] > Fixed iOS builds > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318463&action=review > > > Source/WebCore/editing/Editor.cpp:331 > > + storeMode = DataTransfer::StoreMode::Invalid; > > Possibly helpful to ASSERT() that eventType is one of the other clipboard > event types here, that is not handled above? Done that. > > Source/WebCore/editing/Editor.cpp:346 > > + pasteboard->writePasteboard(dataTransfer->pasteboard()); > > This reminds me -- we'll need to actually implement a lot of these methods > on iOS. Pasteboard::writePasteboard, for example, is stubbed out in > PasteboardIOS.mm Oh, we'd most certainly need to do that. Does that mean we can't currently override contents of the clipboard from copy / cut events right now? > > Source/WebCore/page/DragController.cpp:233 > > + DragOperation srcOpMask = dragData.draggingSourceOperationMask(); > > I don't think this temporary variable adds much clarity. Removed. Created attachment 318470 [details]
Patch for landing
Comment on attachment 318470 [details] Patch for landing Rejecting attachment 318470 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 64/ExtensionStyleSheets.dia -c /Volumes/Data/EWS/WebKit/Source/WebCore/dom/ExtensionStyleSheets.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/ExtensionStyleSheets.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/DragController.o page/DragController.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/4334776 Created attachment 318472 [details]
Patch for landing
Comment on attachment 318472 [details]
Patch for landing
Oops, I broke internal iOS builds.
Created attachment 318476 [details]
Patch for landing
Comment on attachment 318476 [details]
Patch for landing
Wait for EWS.
Comment on attachment 318476 [details] Patch for landing Clearing flags on attachment: 318476 Committed r220935: <http://trac.webkit.org/changeset/220935> All reviewed patches have been landed. Closing bug. |