Bug 175690 – Only generate offline asm for the ARCHS (xcodebuild) or the current system (CMake)

• Component: New Bugs
• Status: RESOLVED FIXED

[Keith Miller]

Only generate offline asm for the ARCHS (xcodebuild) or the current system (CMake)

[Keith Miller]

Created attachment 318432 [details]
Patch

[JF Bastien]

Comment on attachment 318432 [details]
Patch

r=me

[Joseph Pecoraro]

Comment on attachment 318432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318432&action=review

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:9910
> +			shellScript = "set -e\n\nmkdir -p \"${BUILT_PRODUCTS_DIR}/LLIntOffsets/\"\n\n/usr/bin/env ruby \"${SRCROOT}/offlineasm/generate_offset_extractor.rb\" \"-I${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore\" \"${SRCROOT}/llint/LowLevelInterpreter.asm\" \"${BUILT_PRODUCTS_DIR}/LLIntOffsets/LLIntDesiredOffsets.h\" \"${ARCHS}\"\n";

Just a suggestion, but I believe this could go even further:

• For Engineering builds (Release / Debug) if ONLY_ACTIVE_ARCH=YES this could be ${CURRENT_ARCH}.
• For Production builds I'd expect ONLY_ACTIVE_ARCH to always be NO and ${ARCHS} would be appropriate.

That way in my engineering builds when I'm only building for x86_64 I don't also build i386.

[Keith Miller]

(In reply to Joseph Pecoraro from comment #3)
> Comment on attachment 318432 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318432&action=review
> 
> > Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:9910
> > +			shellScript = "set -e\n\nmkdir -p \"${BUILT_PRODUCTS_DIR}/LLIntOffsets/\"\n\n/usr/bin/env ruby \"${SRCROOT}/offlineasm/generate_offset_extractor.rb\" \"-I${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore\" \"${SRCROOT}/llint/LowLevelInterpreter.asm\" \"${BUILT_PRODUCTS_DIR}/LLIntOffsets/LLIntDesiredOffsets.h\" \"${ARCHS}\"\n";
> 
> Just a suggestion, but I believe this could go even further:
> 
> • For Engineering builds (Release / Debug) if ONLY_ACTIVE_ARCH=YES this
> could be ${CURRENT_ARCH}.
> • For Production builds I'd expect ONLY_ACTIVE_ARCH to always be NO and
> ${ARCHS} would be appropriate.
> 
> That way in my engineering builds when I'm only building for x86_64 I don't
> also build i386.

I'm pretty sure if you have ONLY_ACTIVE_ARCH=YES you will only build x86_64. At least that's what I'm seeing locally. I have investigated if that's true everywhere.

[Keith Miller]

Created attachment 318677 [details]
Patch

[Keith Miller]

Trying a simpler method of getting the right names.

[Keith Miller]

Created attachment 318691 [details]
Patch

[Keith Miller]

Created attachment 318708 [details]
Patch

[Michael Saboff]

Comment on attachment 318708 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 318708 [details]
Patch

Clearing flags on attachment: 318708

Committed r220994: <http://trac.webkit.org/changeset/220994>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34004174>

[Csaba Osztrogonác]

(In reply to WebKit Commit Bot from comment #10)
> Comment on attachment 318708 [details]
> Patch
> 
> Clearing flags on attachment: 318708
> 
> Committed r220994: <http://trac.webkit.org/changeset/220994>

It broke the Apple Mac cloop and Apple Windows builds.
See build.webkit.org for details.

[Keith Miller]

(In reply to Csaba Osztrogonác from comment #13)
> (In reply to WebKit Commit Bot from comment #10)
> > Comment on attachment 318708 [details]
> > Patch
> > 
> > Clearing flags on attachment: 318708
> > 
> > Committed r220994: <http://trac.webkit.org/changeset/220994>
> 
> It broke the Apple Mac cloop and Apple Windows builds.
> See build.webkit.org for details.

I'll take a look. Thanks!