Bug 175687

Summary: Number each section in ReadMe.md and add more clarifications
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, cdumez, dewei_zhu, joepeck, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Updates ReadMe.md joepeck: review+

Ryosuke Niwa
Reported 2017-08-17 14:24:04 PDT
Clarify ReadMe.md to address issues Akash encountered.
Attachments
Updates ReadMe.md (7.47 KB, patch)
2017-08-17 14:27 PDT, Ryosuke Niwa 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-08-17 14:27:34 PDT
Created attachment 318420 [details] Updates ReadMe.md
Joseph Pecoraro
Comment 2 2017-08-17 14:47:24 PDT
Comment on attachment 318420 [details] Updates ReadMe.md rs=me
Joseph Pecoraro
Comment 3 2017-08-17 14:48:55 PDT
Comment on attachment 318420 [details] Updates ReadMe.md View in context: https://bugs.webkit.org/attachment.cgi?id=318420&action=review > Websites/perf.webkit.org/ReadMe.md:11 > +1. Install Server.app but do NOT launch/open it. (if you don't want to use Server.app, install PostgreSQL: http://www.postgresql.org/download/macosx/) Why is the NOT so significant here. What goes wrong if it is launched? > Websites/perf.webkit.org/ReadMe.md:98 > +### Instructions if you've accidentally launched Server.app Are these changes that Server.app always makes and we are reverting them?
Ryosuke Niwa
Comment 4 2017-08-17 15:02:44 PDT
(In reply to Joseph Pecoraro from comment #3) > Comment on attachment 318420 [details] > Updates ReadMe.md > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318420&action=review > > > Websites/perf.webkit.org/ReadMe.md:11 > > +1. Install Server.app but do NOT launch/open it. (if you don't want to use Server.app, install PostgreSQL: http://www.postgresql.org/download/macosx/) > > Why is the NOT so significant here. What goes wrong if it is launched? It breaks the setup :( > > Websites/perf.webkit.org/ReadMe.md:98 > > +### Instructions if you've accidentally launched Server.app > > Are these changes that Server.app always makes and we are reverting them? No. If you've launched Server.app, then you have to follow a different set of instructions :(
Ryosuke Niwa
Comment 5 2017-08-17 15:34:51 PDT
Landed in https://trac.webkit.org/changeset/220882.
Radar WebKit Bug Importer
Comment 6 2017-08-17 15:36:15 PDT
<rdar://problem/33951679>
Note You need to log in before you can comment on or make changes to this bug.