Bug 175666

Summary: RenderListItem - Avoid render tree mutation during layout
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, kling, rniwa, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-elcapitan
none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews116 for mac-elcapitan
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
patch
buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan
none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews116 for mac-elcapitan
none
patch none

Description Antti Koivisto 2017-08-17 03:09:56 PDT
See RenderListItem::insertOrMoveMarkerRendererIfNeeded
Comment 1 Antti Koivisto 2017-08-17 03:13:38 PDT
Created attachment 318347 [details]
patch
Comment 2 Build Bot 2017-08-17 04:22:26 PDT
Comment on attachment 318347 [details]
patch

Attachment 318347 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4329559

New failing tests:
css2.1/t0805-c5520-brdr-b-01-e.html
fast/doctypes/002.html
Comment 3 Build Bot 2017-08-17 04:22:27 PDT
Created attachment 318348 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-08-17 04:27:23 PDT
Comment on attachment 318347 [details]
patch

Attachment 318347 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4329564

New failing tests:
css2.1/t0805-c5520-brdr-b-01-e.html
fast/doctypes/002.html
Comment 5 Build Bot 2017-08-17 04:27:25 PDT
Created attachment 318349 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-08-17 04:44:04 PDT
Comment on attachment 318347 [details]
patch

Attachment 318347 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4329565

New failing tests:
css2.1/t0805-c5520-brdr-b-01-e.html
fast/doctypes/002.html
Comment 7 Build Bot 2017-08-17 04:44:05 PDT
Created attachment 318351 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-08-17 04:52:40 PDT
Comment on attachment 318347 [details]
patch

Attachment 318347 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4329585

New failing tests:
fast/doctypes/002.html
fast/lists/marker-before-empty-inline.html
Comment 9 Build Bot 2017-08-17 04:52:42 PDT
Created attachment 318352 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 10 Antti Koivisto 2017-08-17 05:31:55 PDT
Created attachment 318354 [details]
patch
Comment 11 Build Bot 2017-08-17 06:40:44 PDT
Comment on attachment 318354 [details]
patch

Attachment 318354 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4330096

New failing tests:
fast/text-autosizing/ios/lists.html
Comment 12 Build Bot 2017-08-17 06:40:46 PDT
Created attachment 318358 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 13 Build Bot 2017-08-17 06:45:44 PDT
Comment on attachment 318354 [details]
patch

Attachment 318354 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4330101

New failing tests:
fast/text-autosizing/ios/lists.html
Comment 14 Build Bot 2017-08-17 06:45:45 PDT
Created attachment 318360 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 15 Build Bot 2017-08-17 06:54:37 PDT
Comment on attachment 318354 [details]
patch

Attachment 318354 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4330104

New failing tests:
fast/text-autosizing/ios/lists.html
Comment 16 Build Bot 2017-08-17 06:54:38 PDT
Created attachment 318361 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 17 Antti Koivisto 2017-08-17 07:04:06 PDT
Created attachment 318362 [details]
patch
Comment 18 Antti Koivisto 2017-08-17 07:30:47 PDT
<rdar://problem/33402770>
Comment 19 WebKit Commit Bot 2017-08-17 08:19:42 PDT
Comment on attachment 318362 [details]
patch

Clearing flags on attachment: 318362

Committed r220858: <http://trac.webkit.org/changeset/220858>
Comment 20 WebKit Commit Bot 2017-08-17 08:19:44 PDT
All reviewed patches have been landed.  Closing bug.