Bug 175666

Summary:

RenderListItem - Avoid render tree mutation during layout

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, kling, rniwa, simon.fraser, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
patch	buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
patch	none

Antti Koivisto

Reported 2017-08-17 03:09:56 PDT

See RenderListItem::insertOrMoveMarkerRendererIfNeeded

Attachments
patch (7.53 KB, patch) 2017-08-17 03:13 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.19 MB, application/zip) 2017-08-17 04:22 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.33 MB, application/zip) 2017-08-17 04:27 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.99 MB, application/zip) 2017-08-17 04:44 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (1.16 MB, application/zip) 2017-08-17 04:52 PDT, Build Bot	no flags	Details
patch (14.29 KB, patch) 2017-08-17 05:31 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.11 MB, application/zip) 2017-08-17 06:40 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.20 MB, application/zip) 2017-08-17 06:45 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.92 MB, application/zip) 2017-08-17 06:54 PDT, Build Bot	no flags	Details
patch (15.75 KB, patch) 2017-08-17 07:04 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2017-08-17 03:13:38 PDT

Created attachment 318347 [details] patch

Build Bot

Comment 2 2017-08-17 04:22:26 PDT

Comment on attachment 318347 [details] patch Attachment 318347 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4329559 New failing tests: css2.1/t0805-c5520-brdr-b-01-e.html fast/doctypes/002.html

Build Bot

Comment 3 2017-08-17 04:22:27 PDT

Created attachment 318348 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-08-17 04:27:23 PDT

Comment on attachment 318347 [details] patch Attachment 318347 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4329564 New failing tests: css2.1/t0805-c5520-brdr-b-01-e.html fast/doctypes/002.html

Build Bot

Comment 5 2017-08-17 04:27:25 PDT

Created attachment 318349 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-08-17 04:44:04 PDT

Comment on attachment 318347 [details] patch Attachment 318347 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4329565 New failing tests: css2.1/t0805-c5520-brdr-b-01-e.html fast/doctypes/002.html

Build Bot

Comment 7 2017-08-17 04:44:05 PDT

Created attachment 318351 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-08-17 04:52:40 PDT

Comment on attachment 318347 [details] patch Attachment 318347 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4329585 New failing tests: fast/doctypes/002.html fast/lists/marker-before-empty-inline.html

Build Bot

Comment 9 2017-08-17 04:52:42 PDT

Created attachment 318352 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Antti Koivisto

Comment 10 2017-08-17 05:31:55 PDT

Created attachment 318354 [details] patch

Build Bot

Comment 11 2017-08-17 06:40:44 PDT

Comment on attachment 318354 [details] patch Attachment 318354 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4330096 New failing tests: fast/text-autosizing/ios/lists.html

Build Bot

Comment 12 2017-08-17 06:40:46 PDT

Created attachment 318358 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 13 2017-08-17 06:45:44 PDT

Comment on attachment 318354 [details] patch Attachment 318354 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4330101 New failing tests: fast/text-autosizing/ios/lists.html

Build Bot

Comment 14 2017-08-17 06:45:45 PDT

Created attachment 318360 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 15 2017-08-17 06:54:37 PDT

Comment on attachment 318354 [details] patch Attachment 318354 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4330104 New failing tests: fast/text-autosizing/ios/lists.html

Build Bot

Comment 16 2017-08-17 06:54:38 PDT

Created attachment 318361 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 17 2017-08-17 07:04:06 PDT

Created attachment 318362 [details] patch

Antti Koivisto

Comment 18 2017-08-17 07:30:47 PDT

<rdar://problem/33402770>

WebKit Commit Bot

Comment 19 2017-08-17 08:19:42 PDT

Comment on attachment 318362 [details] patch Clearing flags on attachment: 318362 Committed r220858: <http://trac.webkit.org/changeset/220858>

WebKit Commit Bot

Comment 20 2017-08-17 08:19:44 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.