Summary: | Automation: takeScreenshot should use the visible content rect not the document rect | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, joepeck, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2017-08-17 02:54:41 PDT
Created attachment 318346 [details]
Patch
Comment on attachment 318346 [details]
Patch
r=me
I don't think there are any Selenium tests that cover interesting screenshot corner cases.
(In reply to Brian Burg from comment #2) > Comment on attachment 318346 [details] > Patch > > r=me > > I don't think there are any Selenium tests that cover interesting screenshot > corner cases. Right, they just check the commands return any data. I did several manual tests comparing with firefox and chrome. Committed r221246: <http://trac.webkit.org/changeset/221246> |