Bug 175656

Summary: Add back the ability to disable MASM_PROBE from the build.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, clopez, cmarcelo, dbates, fpizlo, jfbastien, keith_miller, msaboff, ossy, pvollan, rmorisset, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175514    
Attachments:
Description Flags
proposed patch. ysuzuki: review+

Mark Lam
Reported 2017-08-16 21:42:55 PDT
This is needed for ports that the existing MASM_PROBE implementation doesn't work with. Note that if the DFG_JIT will be disabled by default if !ENABLE(MASM_PROBE).
Attachments
proposed patch. (12.77 KB, patch)
2017-08-16 21:49 PDT, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-08-16 21:44:31 PDT
<rdar://problem/33933720>
Mark Lam
Comment 2 2017-08-16 21:49:58 PDT
Created attachment 318325 [details] proposed patch.
Yusuke Suzuki
Comment 3 2017-08-16 21:55:58 PDT
Comment on attachment 318325 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=318325&action=review r=me with comment. > Source/WTF/wtf/Platform.h:818 > +#if PLATFORM(GTK) && CPU(ARM_THUMB2) Could you add a FIXME with URL to track this?
Mark Lam
Comment 4 2017-08-16 21:58:01 PDT
Thanks for the review. (In reply to Yusuke Suzuki from comment #3) > > Source/WTF/wtf/Platform.h:818 > > +#if PLATFORM(GTK) && CPU(ARM_THUMB2) > > Could you add a FIXME with URL to track this? Will do. It's tracked in https://bugs.webkit.org/show_bug.cgi?id=175514.
Mark Lam
Comment 5 2017-08-16 22:09:53 PDT
Landed in r220823: <http://trac.webkit.org/r220823>.
Mark Lam
Comment 6 2017-08-21 21:58:30 PDT
Follow up fix for a typo: should be OS(WINDOWS), not OS(WINDOW), in r221003: <http://trac.webkit.org/r221003>.
Note You need to log in before you can comment on or make changes to this bug.