| Summary: | check-webkit-style shouldn't check spacing in #elif preprocessor lines | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yoshiaki Jitsukawa <yoshiaki.jitsukawa> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, buildbot, commit-queue, don.olmstead, glenn, lforschler, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yoshiaki Jitsukawa
2017-08-16 19:09:36 PDT
Created attachment 318317 [details]
Patch
e.g. ./platform/spi/mac/AVFoundationSPI.h:#if __has_include(<AVFoundation/AVSampleBufferRenderSynchronizer.h>) I'm pretty sure check-webkit-style has tests. (In reply to Alex Christensen from comment #3) > I'm pretty sure check-webkit-style has tests. Yes https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py#L2035 (In reply to Yoshiaki Jitsukawa from comment #4) > (In reply to Alex Christensen from comment #3) > > I'm pretty sure check-webkit-style has tests. > > Yes > https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/style/ > checkers/cpp_unittest.py#L2035 Ah, the test passes because of "#if" so I needed to change this "#if" to something else. Created attachment 318404 [details]
Patch
Originally I hit this issue with "#elif __has_include.." code so now I think this should be handled by skipping spacing checks for "#elif". Related bug: Bug 125534 - check-webkit-style shouldn't check spacing in #if preprocessor lines Hi Alex, would you review my patch again if you are available? Comment on attachment 318404 [details] Patch Clearing flags on attachment: 318404 Committed r220896: <http://trac.webkit.org/changeset/220896> All reviewed patches have been landed. Closing bug. Thank you for your reviewing, Alex! |