Bug 175648

Summary: [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, dbates, japhet, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2017-08-16 16:52:02 PDT
[Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
Attachments
Patch (98.91 KB, patch)
2017-08-16 17:02 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (97.85 KB, patch)
2017-08-16 17:05 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-08-16 17:02:57 PDT
Created attachment 318306 [details] Patch
Andy Estes
Comment 2 2017-08-16 17:05:11 PDT
Created attachment 318307 [details] Patch
Build Bot
Comment 3 2017-08-16 17:07:18 PDT
Attachment 318307 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h:95: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:154: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebKit/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:44: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 4 2017-08-16 17:08:59 PDT
Comment on attachment 318307 [details] Patch rs=me
WebKit Commit Bot
Comment 5 2017-08-16 18:24:34 PDT
Comment on attachment 318307 [details] Patch Clearing flags on attachment: 318307 Committed r220821: <http://trac.webkit.org/changeset/220821>
WebKit Commit Bot
Comment 6 2017-08-16 18:24:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-08-16 18:25:34 PDT
<rdar://problem/33931836>
Note You need to log in before you can comment on or make changes to this bug.