Bug 175648

Summary: [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, dbates, japhet, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Andy Estes 2017-08-16 16:52:02 PDT
[Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
Comment 1 Andy Estes 2017-08-16 17:02:57 PDT
Created attachment 318306 [details]
Patch
Comment 2 Andy Estes 2017-08-16 17:05:11 PDT
Created attachment 318307 [details]
Patch
Comment 3 Build Bot 2017-08-16 17:07:18 PDT
Attachment 318307 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:100:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h:95:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:154:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:44:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 5 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2017-08-16 17:08:59 PDT
Comment on attachment 318307 [details]
Patch

rs=me
Comment 5 WebKit Commit Bot 2017-08-16 18:24:34 PDT
Comment on attachment 318307 [details]
Patch

Clearing flags on attachment: 318307

Committed r220821: <http://trac.webkit.org/changeset/220821>
Comment 6 WebKit Commit Bot 2017-08-16 18:24:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-08-16 18:25:34 PDT
<rdar://problem/33931836>