Bug 175630

Summary:

Disable CSS regions at compile time

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

CSS

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, kling, koivisto, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch for EWS	none
Patch for EWS II	buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Patch	none

Andreas Kling

Reported 2017-08-16 09:53:43 PDT

Per webkit-dev discussion[1], let's compile without CSS regions for a while and see how we fare. Though there is plenty of code spread outside the guards, I think we can disable the web-facing parts of the feature by simply building without ENABLE_CSS_REGIONS. [1] https://lists.webkit.org/pipermail/webkit-dev/2017-August/029437.html

Attachments
Patch for EWS (12.57 KB, patch) 2017-08-16 09:58 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Patch for EWS II (15.99 KB, patch) 2017-08-17 09:15 PDT, Andreas Kling	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.26 MB, application/zip) 2017-08-17 10:49 PDT, Build Bot	no flags	Details
Patch (21.89 KB, patch) 2017-08-17 10:56 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2017-08-16 09:58:33 PDT

Created attachment 318268 [details] Patch for EWS

Andreas Kling

Comment 2 2017-08-17 09:15:12 PDT

Created attachment 318371 [details] Patch for EWS II

Build Bot

Comment 3 2017-08-17 10:49:44 PDT

Comment on attachment 318371 [details] Patch for EWS II Attachment 318371 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4331095 New failing tests: tiled-drawing/scrolling/non-fast-region/wheel-handler-in-region.html

Build Bot

Comment 4 2017-08-17 10:49:46 PDT

Created attachment 318382 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Andreas Kling

Comment 5 2017-08-17 10:56:18 PDT

Created attachment 318384 [details] Patch

Antti Koivisto

Comment 6 2017-08-17 10:58:12 PDT

Comment on attachment 318384 [details] Patch r=me

WebKit Commit Bot

Comment 7 2017-08-17 12:18:59 PDT

Comment on attachment 318384 [details] Patch Clearing flags on attachment: 318384 Committed r220870: <http://trac.webkit.org/changeset/220870>

WebKit Commit Bot

Comment 8 2017-08-17 12:19:01 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2017-08-17 12:21:06 PDT

<rdar://problem/33946956>

Note You need to log in before you can comment on or make changes to this bug.