Bug 175630

Summary: Disable CSS regions at compile time
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, kling, koivisto, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for EWS
none
Patch for EWS II
buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
none
Patch none

Description Andreas Kling 2017-08-16 09:53:43 PDT 
Per webkit-dev discussion[1], let's compile without CSS regions for a while and see how we fare.

Though there is plenty of code spread outside the guards, I think we can disable the web-facing parts of the feature by simply building without ENABLE_CSS_REGIONS.

[1] https://lists.webkit.org/pipermail/webkit-dev/2017-August/029437.html
Comment 1 Andreas Kling 2017-08-16 09:58:33 PDT 
Created attachment 318268 [details]
Patch for EWS
Comment 2 Andreas Kling 2017-08-17 09:15:12 PDT 
Created attachment 318371 [details]
Patch for EWS II
Comment 3 Build Bot 2017-08-17 10:49:44 PDT 
Comment on attachment 318371 [details]
Patch for EWS II

Attachment 318371 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4331095

New failing tests:
tiled-drawing/scrolling/non-fast-region/wheel-handler-in-region.html
Comment 4 Build Bot 2017-08-17 10:49:46 PDT 
Created attachment 318382 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 5 Andreas Kling 2017-08-17 10:56:18 PDT 
Created attachment 318384 [details]
Patch
Comment 6 Antti Koivisto 2017-08-17 10:58:12 PDT 
Comment on attachment 318384 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2017-08-17 12:18:59 PDT 
Comment on attachment 318384 [details]
Patch

Clearing flags on attachment: 318384

Committed r220870: <http://trac.webkit.org/changeset/220870>
Comment 8 WebKit Commit Bot 2017-08-17 12:19:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-08-17 12:21:06 PDT 
<rdar://problem/33946956>