Bug 175624

Summary: Update track-datacue.html test to the current code
Product: WebKit Reporter: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Component: MediaAssignee: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, eric.carlson, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ms2ger (he/him; ⌚ UTC+1/+2)
Reported 2017-08-16 03:41:26 PDT
.
Attachments
Patch (5.43 KB, patch)
2017-08-16 03:45 PDT, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
Patch (7.63 KB, patch)
2017-08-18 01:35 PDT, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 1 2017-08-16 03:45:46 PDT
Created attachment 318249 [details] Patch
Sam Weinig
Comment 2 2017-08-16 10:02:35 PDT
With the change, can it be unskipped on the other platforms as well?
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 3 2017-08-17 00:23:06 PDT
I don't know. Could you give me pointers on how to check the results before landing?
Sam Weinig
Comment 4 2017-08-17 10:39:30 PDT
Probably the easiest way yo get a first pass idea is just to upload a patch here and see if any of the bots here complain.
Sam Weinig
Comment 5 2017-08-17 10:39:56 PDT
CC'ing Eric who would have a better idea about these specific tests.
Eric Carlson
Comment 6 2017-08-17 11:16:35 PDT
It should work everywhere.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 7 2017-08-18 01:35:00 PDT
Created attachment 318487 [details] Patch
WebKit Commit Bot
Comment 8 2017-08-18 02:24:38 PDT
Comment on attachment 318487 [details] Patch Clearing flags on attachment: 318487 Committed r220912: <http://trac.webkit.org/changeset/220912>
WebKit Commit Bot
Comment 9 2017-08-18 02:24:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-08-18 02:25:18 PDT
<rdar://problem/33959776>
Eric Carlson
Comment 11 2017-08-18 09:13:41 PDT
Thank you @Ms2ger!
Note You need to log in before you can comment on or make changes to this bug.