Summary: | Speedometer: Update to modern Angular 1 version | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mathias Bynens <mathias> | ||||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | addyo, buildbot, cdumez, commit-queue, mathias, rniwa, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 172339 | ||||||||||||
Attachments: |
|
Description
Mathias Bynens
2017-08-16 03:36:47 PDT
Created attachment 318248 [details]
Patch
Created attachment 318250 [details]
Patch
Hmm… Why are the style checks failing? Is there an easy way to run these tests locally? FWIW, I didn’t get any errors when running `webkit-patch`: $ webkit-patch upload --request-commit Total errors found: 0 in 16 files […] Created attachment 318256 [details]
Patch
(In reply to Mathias Bynens from comment #3) > Hmm… Why are the style checks failing? Is there an easy way to run these > tests locally? > > FWIW, I didn’t get any errors when running `webkit-patch`: > > $ webkit-patch upload --request-commit > Total errors found: 0 in 16 files > […] Seems to have been caused by me renaming `readme.md` to `README.md` (for consistency). The same patch minus that change passes the checks. 🤷🏼 Created attachment 318257 [details]
Results before and after the patch
Comment on attachment 318256 [details] Patch Clearing flags on attachment: 318256 Committed r220801: <http://trac.webkit.org/changeset/220801> All reviewed patches have been landed. Closing bug. |