| Summary: | [WebCrypto] Push WorkQueue dispatches for EC algorithms into shared code | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | buildbot, jiewen_tan, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Zan Dobersek
2017-08-15 21:56:20 PDT
Created attachment 318228 [details]
WIP patch
Attachment 318228 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 318479 [details]
Patch
Ready for review.
Created attachment 318624 [details]
Patch
Created attachment 319069 [details]
Patch
Comment on attachment 319069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319069&action=review Looks good to me. r=me. Good job. > Source/WebCore/crypto/algorithms/CryptoAlgorithmECDH.cpp:117 > + context.ref(); It maybe better to add a comment here to state that this is the only special case that we have this unifiedCallback. Therefore, we cannot utilize the dispatchOperation infrastructure, and it is not necessary to make one for it. Created attachment 319249 [details]
Patch for landing
Comment on attachment 319249 [details] Patch for landing Clearing flags on attachment: 319249 Committed r221293: <http://trac.webkit.org/changeset/221293> All reviewed patches have been landed. Closing bug. |