Bug 175618

Summary: 2-3% of main thread time under UTTypeCreatePreferredIdentifierForTag on wunderground map
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2017-08-15 21:35:27 PDT
2-3% of main thread time under UTTypeCreatePreferredIdentifierForTag on wunderground map
Attachments
Patch (23.87 KB, patch)
2017-08-15 21:36 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (24.07 KB, patch)
2017-08-15 21:40 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (24.03 KB, patch)
2017-08-15 21:41 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (24.24 KB, patch)
2017-08-15 21:56 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (24.24 KB, patch)
2017-08-15 22:00 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (24.48 KB, patch)
2017-08-15 22:07 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (24.49 KB, patch)
2017-08-15 22:20 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (23.31 KB, patch)
2017-08-15 23:05 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (23.30 KB, patch)
2017-08-16 11:37 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2017-08-15 21:36:00 PDT
Created attachment 318222 [details] Patch
Tim Horton
Comment 2 2017-08-15 21:40:12 PDT
Created attachment 318223 [details] Patch
Tim Horton
Comment 3 2017-08-15 21:41:47 PDT
Created attachment 318224 [details] Patch
Simon Fraser (smfr)
Comment 4 2017-08-15 21:53:30 PDT
Comment on attachment 318224 [details] Patch r=me if you fix the iOS build.
Tim Horton
Comment 5 2017-08-15 21:56:28 PDT
Created attachment 318226 [details] Patch
Tim Horton
Comment 6 2017-08-15 22:00:57 PDT
Created attachment 318227 [details] Patch
Tim Horton
Comment 7 2017-08-15 22:07:17 PDT
Created attachment 318230 [details] Patch
Tim Horton
Comment 8 2017-08-15 22:20:57 PDT
Created attachment 318233 [details] Patch
Tim Horton
Comment 9 2017-08-15 23:05:46 PDT
Created attachment 318237 [details] Patch
Tim Horton
Comment 10 2017-08-15 23:06:32 PDT
😭
Alexey Proskuryakov
Comment 11 2017-08-16 07:56:20 PDT
Comment on attachment 318237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318237&action=review > Source/WebCore/platform/network/mac/UTIUtilities.mm:90 > + static NeverDestroyed<TinyLRUCache<String, String, 16, UTIFromMIMETypeCachePolicy>> cache; Is this code only ever called from main thread?
Tim Horton
Comment 12 2017-08-16 10:50:32 PDT
(In reply to Alexey Proskuryakov from comment #11) > Comment on attachment 318237 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318237&action=review > > > Source/WebCore/platform/network/mac/UTIUtilities.mm:90 > > + static NeverDestroyed<TinyLRUCache<String, String, 16, UTIFromMIMETypeCachePolicy>> cache; > > Is this code only ever called from main thread? I believe so (looking through the callers). I threw an assert in and am running the tests, and I'll keep it in the landed patch.
Tim Horton
Comment 13 2017-08-16 11:37:55 PDT
Created attachment 318276 [details] Patch
WebKit Commit Bot
Comment 14 2017-08-16 13:49:51 PDT
Comment on attachment 318276 [details] Patch Clearing flags on attachment: 318276 Committed r220808: <http://trac.webkit.org/changeset/220808>
WebKit Commit Bot
Comment 15 2017-08-16 13:49:53 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 16 2017-08-16 13:51:01 PDT
<rdar://problem/33925934>
Note You need to log in before you can comment on or make changes to this bug.