Fetch / Beacon: Use "application/octet-stream" Content-Type for payloads of type ArrayBuffer / ArrayBufferView

• Component: DOM
• Status: RESOLVED FIXED

[Chris Dumez]

Use "application/octet-stream" Content-Type for payloads of type ArrayBuffer / ArrayBufferView in Fetch & Beacon. If we don't set a Content-Type header, our underlying network stack is going to add a "application/x-www-form-urlencoded" Content-Type header, which is worse.

[Chris Dumez]

Created attachment 318176 [details]
Patch

[Chris Dumez]

Created attachment 318186 [details]
Patch

[youenn fablet]

Comment on attachment 318186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318186&action=review

> Source/WebCore/Modules/fetch/FetchBody.cpp:65
> +        contentType = HTTPHeaderValues::octetStreamContentType();

Can we add a FIXME stating that we should remove it once all WebKit network stacks support sending no CT?

[Chris Dumez]

Created attachment 318188 [details]
Patch

[youenn fablet]

Comment on attachment 318188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318188&action=review

> Source/WebCore/Modules/fetch/FetchBody.cpp:65
> +        // FIXME: We should not set a Content-Type here but we need to do this until our network stack

s/our/all

> Source/WebCore/Modules/fetch/FetchBody.cpp:72
> +        // FIXME: We should not set a Content-Type here but we need to do this until our network stack

ditto

> LayoutTests/ChangeLog:13
> [phone]  Chris Dumez  <[e-mail]>

dup log and commit I guess

[Chris Dumez]

Created attachment 318204 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 318204 [details]
Patch

Clearing flags on attachment: 318204

Committed r220779: <http://trac.webkit.org/changeset/220779>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33910024>

[Fujii Hironori]

3 LayoutTests of iOS port fail:

http/tests/blink/sendbeacon/beacon-same-origin.html
http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html
http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html

https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r220779%20(3641)/results.html

[Ryan Haddad]

(In reply to Fujii Hironori from comment #10)
> 3 LayoutTests of iOS port fail:
> 
> http/tests/blink/sendbeacon/beacon-same-origin.html
> http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html
> http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html
> 
> https://build.webkit.org/results/
> Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r220779%20(3641)/
> results.html
The same 3 are failing on Sierra:

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r220795%20(3640)/results.html

[Chris Dumez]

(In reply to Ryan Haddad from comment #11)
> (In reply to Fujii Hironori from comment #10)
> > 3 LayoutTests of iOS port fail:
> > 
> > http/tests/blink/sendbeacon/beacon-same-origin.html
> > http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html
> > http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html
> > 
> > https://build.webkit.org/results/
> > Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r220779%20(3641)/
> > results.html
> The same 3 are failing on Sierra:
> 
> https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/
> r220795%20(3640)/results.html

Follow-up landed in <http://trac.webkit.org/changeset/220796>.