| Summary: | [Cache API] Ensure ResourceResponse is not null when redirected/tainting/type fields are set | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | beidson, cdumez, commit-queue, sam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2017-08-14 10:06:52 PDT
Created attachment 318046 [details]
Patch
Comment on attachment 318046 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318046&action=review > Source/WebCore/platform/network/ResourceResponseBase.cpp:237 > + lazyInit(CommonFieldsOnly); I don't think this is needed since m_type is not used to initialize the underlying network object. m_type is a Webkit concept at this point, not an underlying network layer concept. > Source/WebCore/platform/network/ResourceResponseBase.cpp:242 > +void ResourceResponseBase::setRedirected(bool isRedirected) Is this one really needed? I'd expect such responses to have a URL. > Source/WebCore/platform/network/ResourceResponseBase.cpp:249 > +void ResourceResponseBase::setTainting(Tainting tainting) Is this one really needed? I'd expect such responses to have a URL. Created attachment 318178 [details]
Patch
Comment on attachment 318178 [details] Patch Clearing flags on attachment: 318178 Committed r220764: <http://trac.webkit.org/changeset/220764> All reviewed patches have been landed. Closing bug. |