Summary: | [CoordGraphics] Simplify CoordinatedGraphicsScene state updates | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, cgarcia, magomez, mcatanzaro, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Zan Dobersek
2017-08-14 04:23:22 PDT
Created attachment 318030 [details]
Patch
Attachment 318030 [details] did not pass style-queue:
ERROR: Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:234: Multi line control clauses should use braces. [whitespace/braces] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 318030 [details]
Patch
I never liked that render queue thing \o/
Comment on attachment 318030 [details] Patch Clearing flags on attachment: 318030 Committed r220700: <http://trac.webkit.org/changeset/220700> All reviewed patches have been landed. Closing bug. Debug bot is exiting early after this change, hitting an assert: ASSERTION FAILED: m_surfaces.contains(atlasID) /home/slave/webkitgtk/gtk-linux-64-debug/build/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp(449) : void WebKit::CoordinatedGraphicsScene::removeUpdateAtlas(uint32_t) Reverted r220700 for reason: Broke debug bot Committed r220742: <http://trac.webkit.org/changeset/220742> Created attachment 318240 [details]
Patch
Attachment 318240 [details] did not pass style-queue:
ERROR: Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:234: Multi line control clauses should use braces. [whitespace/braces] [4]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 318241 [details]
Patch
Comment on attachment 318241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318241&action=review > Source/WebKit/ChangeLog:28 > + Outside of CoordinatedGraphicsScene and ThreadedCompositor classes, the > + CompositingCoordinator class now passes the atlases-to-remove Vector by > + a const lvalue reference down to ThreadedCompositor, and then manually > + clears the Vector. Before the Vector was passed as an rvalue reference, > + depending on the ThreadedCompositor code to clear out the original Vector > + object by moving its resources into the functor object. This doesn't occur > + anymore because the Vector object is now appended to another Vector. This describes the problem that was causing asserts. Attachment 318241 [details] did not pass style-queue:
ERROR: Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:234: Multi line control clauses should use braces. [whitespace/braces] [4]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 318241 [details] Patch Clearing flags on attachment: 318241 Committed r220792: <http://trac.webkit.org/changeset/220792> All reviewed patches have been landed. Closing bug. |