| Summary: | Caging shouldn't have to use a patchpoint for adding | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, ggaren, jfbastien, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 175493 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Filip Pizlo
2017-08-11 10:24:23 PDT
Created attachment 317960 [details]
I think this should work
Created attachment 317977 [details]
maybe the patch
Created attachment 317979 [details]
the patch
Comment on attachment 317979 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=317979&action=review r=me > Source/JavaScriptCore/ChangeLog:18 > + hoist it - that would require quite a bit of algebraic reasoning. But this is the only case we know > + where our current constant reassociation heuristics are wrong is caging. So, we can get away with /this is the only case we know where/the only case we know of where/. |