Bug 17544

Summary: Rename testkjs since it's not just a test tool (but "js" is already taken by Mozilla)
Product: WebKit Reporter: Sam Weinig <sam>
Component: JavaScriptCoreAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: alp, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
a newer attempt oliver: review+

Description Sam Weinig 2008-02-25 17:36:36 PST
It's about time we rename this baby.  I am going with 'js'.
Comment 1 Sam Weinig 2008-02-25 17:42:56 PST
Created attachment 19366 [details]
patch

I need to fix VS before landing this.
Comment 2 Mark Rowe (bdash) 2008-02-25 18:10:42 PST
I don't think that using "js" as the binary name is a good idea.  SpiderMonkey's binary is already named "js" so I think this would introduce unnecessary ambiguity.
Comment 3 Anders Carlsson 2008-02-26 22:12:19 PST
Comment on attachment 19366 [details]
patch

r=me
Comment 4 Alp Toker 2008-02-26 22:49:52 PST
Some people were concerned about 'js' conflicting but as far as I can tell from the Debian package list, a good way of finding out if anything under the sun puts a command in the path, 'js' isn't taken.

So this change looks good.

'jscore' would be OK too and may help avoid confusion with other internal 'js' commands, but this isn't a big deal. The other suggestion, 'jsc', is taken by the JScript compiler and should be avoided.
Comment 5 Mark Rowe (bdash) 2008-02-26 22:59:13 PST
That just goes to show that Debian doesn't know everything ;-)  The MacPorts "spidermonkey" package installs a binary named "js".  The Debian folk have renamed it to "smjs", presumably because they felt "js" was too generic.
Comment 6 Mark Rowe (bdash) 2008-02-26 23:02:04 PST
Actually, SpiderMonkey on Debian *does* create /usr/bin/js.  It's created using their "alternatives" system so it is created as a symlink to /usr/bin/smjs.  Going with "js" would mean Debian would need to rename the binary for their packages.
Comment 7 Alp Toker 2008-02-26 23:12:46 PST
(In reply to comment #6)
> Actually, SpiderMonkey on Debian *does* create /usr/bin/js.  It's created using
> their "alternatives" system so it is created as a symlink to /usr/bin/smjs. 
> Going with "js" would mean Debian would need to rename the binary for their
> packages.
> 

Well spotted, picking a less ambiguous name would indeed be useful for a portable tool like this. I'll take back my comment about 'js' being a good name.
Comment 8 Darin Adler 2008-04-02 03:01:29 PDT
Here are some suggestions I have for names (some good, some obviously bad):

    - How about "jsc" for JavaScriptCore? If people think the "c" stands for compiler, it's no big problem because over time we'll be using more and more compiler technology, although it might make them look for the "a.out" file.
    - Or "jsx" for "JavaScript execute"?
    - Or "xjs" for "execute JavaScript"?
    - Or "webkit-js"?
    - Or "jscript"?
    - Or "javascript"?
    - Or "JavaScript"?
Comment 9 Maciej Stachowiak 2008-04-27 22:57:23 PDT
More suggestions:

- jscjs
- sqfjs
- jssqf

Comment 10 Maciej Stachowiak 2008-06-15 03:01:08 PDT
Created attachment 21707 [details]
a newer attempt

This does not do any file splits or make a new directory for the command-line tool, but it does rename it from testkjs to jsc, and updates all build systems and scripts.
Comment 11 Cameron Zwarich (cpst) 2008-06-22 18:10:50 PDT
This was done in r34566 and some later revisions.