Bug 175393

Summary: [Repaint from Layout Removal] Move layer repaint rects into a map
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zalan: review+

Dave Hyatt
Reported 2017-08-09 12:19:45 PDT
Move layer repaint rects into a map. Since many layers aren't self-painting, they're wasting space holding those rects. In addition, once we start caching rects for RenderLayerModelObjects that don't have layers (i.e., everyone using a LayoutRepainter right now), then we'll want to have a common structure.
Attachments
Patch (16.29 KB, patch)
2017-08-09 12:22 PDT, Dave Hyatt 		zalan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2017-08-09 12:22:25 PDT
Created attachment 317728 [details] Patch
Build Bot
Comment 2 2017-08-09 12:24:09 PDT
Attachment 317728 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderLayerModelObject.h:33: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/rendering/RenderLayerModelObject.h:35: The parameter name "geometryMap" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2017-08-09 14:03:17 PDT
Landed in r220479.
Note You need to log in before you can comment on or make changes to this bug.