Summary: | Add "display" to FontFace Javascript object | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||
Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, dino, jonlee, mmaxfield, simon.fraser, thorton, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | Other | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 175384 | ||||||||||||
Bug Blocks: | 167332 | ||||||||||||
Attachments: |
|
Description
Myles C. Maxfield
2017-08-09 08:18:51 PDT
The spec doesn't list this property. (In reply to Myles C. Maxfield from comment #2) > The spec doesn't list this property. https://drafts.csswg.org/css-font-loading/#fontface-interface https://github.com/tabatkins/specs/issues/54 https://github.com/w3c/csswg-drafts/issues/1360 https://codereview.chromium.org/2640753002 https://bugzilla.mozilla.org/show_bug.cgi?id=1157064 https://hg.mozilla.org/mozilla-central/rev/6d9b17e5e7b5 https://chromium.googlesource.com/chromium/src/+/ec812adbe02d56c9efafcaa77c7dfd9121510959 Given that all the existing implementations of font-display do this, we probably do too. I've (re)opened https://github.com/w3c/csswg-drafts/issues/1360 for the spec. Created attachment 322882 [details]
WIP
Attachment 322882 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 322902 [details]
WIP
Attachment 322902 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 322929 [details]
Patch
Created attachment 322930 [details]
Patch
Comment on attachment 322930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322930&action=review > LayoutTests/fast/text/font-loading-font-display.html:21 > +let values = ["auto", "block", "swap", "fallback", "optional"]; Maybe test setting to an invalid value? Committed r222949: <http://trac.webkit.org/changeset/222949> |