Bug 175383

Summary:

Add "display" to FontFace Javascript object

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

Text

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, dino, jonlee, mmaxfield, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

175384

Bug Blocks:

167332

Attachments:

Description	Flags
WIP	none
WIP	none
Patch	none
Patch	simon.fraser: review+

Myles C. Maxfield

Reported 2017-08-09 08:18:51 PDT

1) Figure out (from the relevant standardization body) if it should be present 2) If so, implement it

Attachments
WIP (5.52 KB, patch) 2017-10-05 12:29 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (5.83 KB, patch) 2017-10-05 13:17 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (9.03 KB, patch) 2017-10-05 16:02 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (9.10 KB, patch) 2017-10-05 16:03 PDT, Myles C. Maxfield	simon.fraser: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-08-09 15:34:44 PDT

<rdar://problem/33813239>

Myles C. Maxfield

Comment 2 2017-08-10 09:59:00 PDT

The spec doesn't list this property.

Myles C. Maxfield

Comment 3 2017-08-10 09:59:06 PDT

(In reply to Myles C. Maxfield from comment #2) > The spec doesn't list this property. https://drafts.csswg.org/css-font-loading/#fontface-interface

Myles C. Maxfield

Comment 4 2017-08-10 11:55:32 PDT

https://github.com/tabatkins/specs/issues/54 https://github.com/w3c/csswg-drafts/issues/1360 https://codereview.chromium.org/2640753002 https://bugzilla.mozilla.org/show_bug.cgi?id=1157064

Myles C. Maxfield

Comment 5 2017-08-10 12:00:12 PDT

https://hg.mozilla.org/mozilla-central/rev/6d9b17e5e7b5 https://chromium.googlesource.com/chromium/src/+/ec812adbe02d56c9efafcaa77c7dfd9121510959

Myles C. Maxfield

Comment 6 2017-08-10 12:04:52 PDT

Given that all the existing implementations of font-display do this, we probably do too. I've (re)opened https://github.com/w3c/csswg-drafts/issues/1360 for the spec.

Myles C. Maxfield

Comment 7 2017-10-05 12:29:10 PDT

Created attachment 322882 [details] WIP

Build Bot

Comment 8 2017-10-05 12:30:21 PDT

Attachment 322882 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 9 2017-10-05 13:17:17 PDT

Created attachment 322902 [details] WIP

Build Bot

Comment 10 2017-10-05 13:18:56 PDT

Attachment 322902 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 11 2017-10-05 16:02:14 PDT

Created attachment 322929 [details] Patch

Myles C. Maxfield

Comment 12 2017-10-05 16:03:09 PDT

Created attachment 322930 [details] Patch

Simon Fraser (smfr)

Comment 13 2017-10-05 17:57:43 PDT

Comment on attachment 322930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322930&action=review > LayoutTests/fast/text/font-loading-font-display.html:21 > +let values = ["auto", "block", "swap", "fallback", "optional"]; Maybe test setting to an invalid value?

Myles C. Maxfield

Comment 14 2017-10-05 18:25:06 PDT

Committed r222949: <http://trac.webkit.org/changeset/222949>

Note You need to log in before you can comment on or make changes to this bug.