Summary: | Can't build CollectorHeapIntrospector.cpp as a standalone file outside of AllInOneFile.cpp | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Mentovai <mark> | ||||||
Component: | JavaScriptCore | Assignee: | Mark Mentovai <mark> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 17493 | ||||||||
Attachments: |
|
Description
Mark Mentovai
2008-02-25 14:13:33 PST
Created attachment 19355 [details]
Move the definition of CollectorHeap into collector.h, and provide a "using" declaration for WTF::RemoteMemoryReader
Comment on attachment 19355 [details] Move the definition of CollectorHeap into collector.h, and provide a "using" declaration for WTF::RemoteMemoryReader The patch looks good to me, but it will need a ChangeLog before it can be landed. Please see the instructions at <http://webkit.org/coding/contributing.html> and attach an updated patch with a ChangeLog entry for JavaScriptCore. Created attachment 19356 [details]
v2, includes ChangeLog entry
Whoops, sorry about that.
Comment on attachment 19356 [details]
v2, includes ChangeLog entry
r=me.
|