Summary: | Web Inspector: Make styles sidebar always LTR | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||||||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, inspector-bugzilla-changes, joepeck, rniwa, webkit-bug-importer | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | All | ||||||||||||||||||
OS: | All | ||||||||||||||||||
Attachments: |
|
Description
Nikita Vasilyev
2017-08-08 16:37:19 PDT
Created attachment 330859 [details]
[Image] Before the patch
(In reply to Nikita Vasilyev from comment #0) > The current version of the styles sidebar aligns text to the left. > > With the spreadsheet model, we can: > - align text to right. > - move checkboxes to the right side. > - flip CSS property names and values. After long consideration, I don't think this makes sense to do. CSS is strictly LTR. Flipping names and values would break copy/pasting, among other things. Created attachment 330860 [details]
Patch for review
Created attachment 330861 [details]
[Image] With patch applied
Comment on attachment 330860 [details] Patch for review Attachment 330860 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6013410 New failing tests: imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-a-bitrate.html accessibility/mac/aria-multiple-liveregions-notification.html Created attachment 330882 [details]
Archive of layout-test-results from ews101 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 330860 [details] Patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=330860&action=review > Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:36 > + this.element.dir = "ltr"; I think this deserves a comment. Does this section titles as well? Should it? Created attachment 330979 [details] [Image] With patch applied 2 (In reply to Joseph Pecoraro from comment #8) > Does this section titles as well? Should it? Does this make the section titles RTL as well?.. Is that what you asked? Yes, it does. I think it would be harder to follow the structure when only the section titles are aligned right. Created attachment 330980 [details]
Patch for review
Comment on attachment 330980 [details] Patch for review Attachment 330980 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6028516 New failing tests: webgl/1.0.2/conformance/uniforms/uniform-default-values.html Created attachment 331011 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 330980 [details]
Patch for review
The test failures are unrelated to the patch.
Comment on attachment 330980 [details]
Patch for review
r=me
Comment on attachment 330980 [details] Patch for review Clearing flags on attachment: 330980 Committed r227228: <https://trac.webkit.org/changeset/227228> All reviewed patches have been landed. Closing bug. |