Bug 175348

Summary: Resource Load Statistics: Merge of dataRecordsRemoved should use std::max()
Product: WebKit Reporter: John Wilander <wilander>
Component: WebCore Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, dbates, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

John Wilander
Reported 2017-08-08 15:18:15 PDT
When we merge dataRecordsRemoved from two different sources we should not add them since that may create a bounce back and forth that inflates the number. Note that this statistic does not affect classification. std::max() is not correct either but closer to correct, especially in real life. A correct solution probably requires keeping separate track of deltas.
Attachments
Patch (1.44 KB, patch)
2017-08-08 15:29 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-08-08 15:18:44 PDT
<rdar://problem/33785695>
John Wilander
Comment 2 2017-08-08 15:29:39 PDT
Created attachment 317629 [details] Patch
Chris Dumez
Comment 3 2017-08-08 16:30:43 PDT
Comment on attachment 317629 [details] Patch r=me
John Wilander
Comment 4 2017-08-08 16:33:52 PDT
Comment on attachment 317629 [details] Patch Thx!
WebKit Commit Bot
Comment 5 2017-08-08 17:03:59 PDT
Comment on attachment 317629 [details] Patch Clearing flags on attachment: 317629 Committed r220430: <http://trac.webkit.org/changeset/220430>
WebKit Commit Bot
Comment 6 2017-08-08 17:04:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.