Summary: | [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||
Component: | WebCore Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, commit-queue, jiewen_tan, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jiewen Tan
2017-08-08 14:52:15 PDT
Created attachment 317624 [details]
Patch
Comment on attachment 317624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317624&action=review > Tools/TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:34 > // A seperate bug is filed about this: <rdar://problem/28507240>. Seems like this comment should be removed too. Comment on attachment 317624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317624&action=review Thanks Alexey for r+ this patch. >> Tools/TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:34 >> // A seperate bug is filed about this: <rdar://problem/28507240>. > > Seems like this comment should be removed too. Oops. Fixed. Created attachment 317727 [details]
Patch for landing
Comment on attachment 317727 [details] Patch for landing Rejecting attachment 317727 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 317727, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/4287273 Committed r220536: <http://trac.webkit.org/changeset/220536> |