Bug 175344

Summary:

[WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebCore Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, jiewen_tan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+, ap: commit-queue-
Patch for landing	commit-queue: commit-queue-

Jiewen Tan

Reported 2017-08-08 14:52:15 PDT

Enable SerializedCryptoKeyWrapTest API tests in iOS simulators.

Attachments
Patch (5.75 KB, patch) 2017-08-08 15:02 PDT, Jiewen Tan	ap: review+ ap: commit-queue-	Details Formatted Diff Diff
Patch for landing (5.76 KB, patch) 2017-08-09 12:15 PDT, Jiewen Tan	commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jiewen Tan

Comment 1 2017-08-08 14:52:30 PDT

<rdar://problem/28507240>

Jiewen Tan

Comment 2 2017-08-08 15:02:03 PDT

Created attachment 317624 [details] Patch

Alexey Proskuryakov

Comment 3 2017-08-08 19:47:59 PDT

Comment on attachment 317624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317624&action=review > Tools/TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:34 > // A seperate bug is filed about this: <rdar://problem/28507240>. Seems like this comment should be removed too.

Jiewen Tan

Comment 4 2017-08-09 12:13:09 PDT

Comment on attachment 317624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317624&action=review Thanks Alexey for r+ this patch. >> Tools/TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:34 >> // A seperate bug is filed about this: <rdar://problem/28507240>. > > Seems like this comment should be removed too. Oops. Fixed.

Jiewen Tan

Comment 5 2017-08-09 12:15:40 PDT

Created attachment 317727 [details] Patch for landing

WebKit Commit Bot

Comment 6 2017-08-09 18:50:01 PDT

Comment on attachment 317727 [details] Patch for landing Rejecting attachment 317727 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 317727, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/4287273

Jiewen Tan

Comment 7 2017-08-10 11:48:05 PDT

Committed r220536: <http://trac.webkit.org/changeset/220536>

Note You need to log in before you can comment on or make changes to this bug.