Bug 175342

Summary:

Don't enable default icon loading in WK1 for apps linked against old SDKs

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, buildbot, commit-queue, rniwa

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	aestes: review+, aestes: commit-queue-
Patch	none
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews112 for mac-elcapitan	none
Patch	none

Brady Eidson

Reported 2017-08-08 14:16:17 PDT

Don't enable default icon loading in WK1 for apps linked against old SDKs We've seen a little fallout from this.

Attachments
Patch (2.74 KB, patch) 2017-08-08 14:17 PDT, Brady Eidson	aestes: review+ aestes: commit-queue-	Details Formatted Diff Diff
Patch (2.77 KB, patch) 2017-08-08 14:24 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (2.76 KB, patch) 2017-08-08 14:24 PDT, Brady Eidson	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.11 MB, application/zip) 2017-08-08 15:17 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-elcapitan (1.97 MB, application/zip) 2017-08-08 15:35 PDT, Build Bot	no flags	Details
Patch (3.05 KB, patch) 2017-08-08 15:55 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2017-08-08 14:16:27 PDT

<rdar://problem/33724060>

Brady Eidson

Comment 2 2017-08-08 14:17:53 PDT

Created attachment 317611 [details] Patch

Andy Estes

Comment 3 2017-08-08 14:23:31 PDT

Comment on attachment 317611 [details] Patch r+ but I think you'll need to fix the iOS build.

Brady Eidson

Comment 4 2017-08-08 14:24:13 PDT

Created attachment 317613 [details] Patch

Brady Eidson

Comment 5 2017-08-08 14:24:44 PDT

Created attachment 317614 [details] Patch

Build Bot

Comment 6 2017-08-08 15:17:13 PDT

Comment on attachment 317614 [details] Patch Attachment 317614 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4279982 New failing tests: http/tests/security/contentSecurityPolicy/allow-favicon.html http/tests/security/contentSecurityPolicy/block-favicon.html

Build Bot

Comment 7 2017-08-08 15:17:14 PDT

Created attachment 317625 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-08-08 15:35:33 PDT

Comment on attachment 317614 [details] Patch Attachment 317614 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4280031 New failing tests: http/tests/security/contentSecurityPolicy/allow-favicon.html http/tests/security/contentSecurityPolicy/block-favicon.html

Build Bot

Comment 9 2017-08-08 15:35:34 PDT

Created attachment 317633 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Brady Eidson

Comment 10 2017-08-08 15:43:38 PDT

SDK check vs tests == :( Will do a WebKit Version Check.

Brady Eidson

Comment 11 2017-08-08 15:55:11 PDT

Created attachment 317635 [details] Patch

WebKit Commit Bot

Comment 12 2017-08-08 16:53:07 PDT

Comment on attachment 317635 [details] Patch Clearing flags on attachment: 317635 Committed r220429: <http://trac.webkit.org/changeset/220429>

WebKit Commit Bot

Comment 13 2017-08-08 16:53:09 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.