Bug 175331

Summary:

Do not layout images when we only need the overflow information.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Patch	none

zalan

Reported 2017-08-08 10:51:57 PDT

ssia.

Attachments
Patch (1.23 KB, patch) 2017-08-08 10:52 PDT, zalan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.45 MB, application/zip) 2017-08-08 12:11 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (10.07 MB, application/zip) 2017-08-08 12:12 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews100 for mac-elcapitan (1.30 MB, application/zip) 2017-08-08 12:20 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (935.81 KB, application/zip) 2017-08-08 14:42 PDT, Build Bot	no flags	Details
Patch (1.44 KB, patch) 2018-04-09 14:29 PDT, zalan	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2017-08-08 10:52:56 PDT

Created attachment 317584 [details] Patch

zalan

Comment 2 2017-08-08 10:53:13 PDT

EWSing.

Build Bot

Comment 3 2017-08-08 12:11:57 PDT

Comment on attachment 317584 [details] Patch Attachment 317584 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4279116 Number of test failures exceeded the failure limit.

Build Bot

Comment 4 2017-08-08 12:11:58 PDT

Created attachment 317597 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-08-08 12:12:14 PDT

Comment on attachment 317584 [details] Patch Attachment 317584 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4279072 New failing tests: media/track/track-cue-rendering-rtl.html media/media-document-audio-controls-visible.html media/video-restricted-invisible-autoplay-allowed-if-audible.html media/video-display-toggle.html media/audio-repaint.html media/audio-controls-rendering.html media/modern-media-controls/audio/audio-controls-metrics.html media/track/regions-webvtt/vtt-region-display.html media/track/track-cue-rendering-vertical.html media/media-controls-clone.html media/video-empty-source.html media/video-poster.html

Build Bot

Comment 6 2017-08-08 12:12:16 PDT

Created attachment 317599 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

zalan

Comment 7 2017-08-08 12:13:34 PDT

They all seem unrelated!

Build Bot

Comment 8 2017-08-08 12:20:02 PDT

Comment on attachment 317584 [details] Patch Attachment 317584 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4279213 Number of test failures exceeded the failure limit.

Build Bot

Comment 9 2017-08-08 12:20:03 PDT

Created attachment 317600 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 10 2017-08-08 14:42:00 PDT

Comment on attachment 317584 [details] Patch Attachment 317584 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4279753 Number of test failures exceeded the failure limit.

Build Bot

Comment 11 2017-08-08 14:42:01 PDT

Created attachment 317617 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

zalan

Comment 12 2018-04-09 14:29:37 PDT

Created attachment 337542 [details] Patch

Simon Fraser (smfr)

Comment 13 2018-04-10 01:01:55 PDT

Comment on attachment 337542 [details] Patch Nice.

WebKit Commit Bot

Comment 14 2018-04-10 07:56:26 PDT

Comment on attachment 337542 [details] Patch Clearing flags on attachment: 337542 Committed r230480: <https://trac.webkit.org/changeset/230480>

WebKit Commit Bot

Comment 15 2018-04-10 07:56:28 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 16 2018-04-10 07:57:54 PDT

<rdar://problem/39314249>

Note You need to log in before you can comment on or make changes to this bug.