Bug 175320

Summary: [Soup] Incorrect conversion in msToSoupDate()
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WPE WebKitAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, buildbot, cgarcia, danw, gns, mcatanzaro, wouter
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Zan Dobersek 2017-08-08 06:51:10 PDT
WTF's monthFromDayInYear() returns a value in the [0,11] range, while soup_date_new() accepts values in the range of [1,12].

Reported and fixed downstream by VaL Doroshchuk:
https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/321
Comment 1 Zan Dobersek 2017-08-08 07:26:34 PDT
Created attachment 317567 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-08-08 07:55:30 PDT
Comment on attachment 317567 [details]
Patch

Thanks!
Comment 3 Zan Dobersek 2017-08-09 00:00:37 PDT
Comment on attachment 317567 [details]
Patch

Clearing flags on attachment: 317567

Committed r220444: <http://trac.webkit.org/changeset/220444>
Comment 4 Zan Dobersek 2017-08-09 00:00:41 PDT
All reviewed patches have been landed.  Closing bug.