Bug 175303

Summary: WKPreferences should conform to NSCopying
Product: WebKit Reporter: Blaze Burg <bburg>
Component: WebKit APIAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, darin, ggaren, mitz, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
For Landing none

Blaze Burg
Reported 2017-08-07 16:29:31 PDT
I need to copy a shared WKPreferences (that is itself far away from a default WKPreferences) and tweak it for particular web views. This seems like the obvious thing to do.
Attachments
Patch (14.63 KB, patch)
2017-08-08 14:49 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch (10.27 KB, patch)
2017-08-09 12:46 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch (10.39 KB, patch)
2017-08-09 15:07 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
For Landing (10.50 KB, patch)
2017-08-10 12:51 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-08-07 16:30:43 PDT
<rdar://problem/33764939>
Blaze Burg
Comment 2 2017-08-08 14:49:34 PDT
Created attachment 317621 [details] Patch
mitz
Comment 3 2017-08-08 14:58:12 PDT
Comment on attachment 317621 [details] Patch Not sure it’s a good idea to make this copyable, much less so publicly, but if we go ahead with this, I suggest that we implement this by making the underlying C++ object copyable. We shouldn’t have to maintain this extra logic in the Objective-C wrapper.
Tim Horton
Comment 4 2017-08-08 15:01:32 PDT
Comment on attachment 317621 [details] Patch Yep, agree. Plus then you could probably use the macros to generate the list instead of doing it manually?
Blaze Burg
Comment 5 2017-08-09 12:46:30 PDT
Created attachment 317730 [details] Patch
Blaze Burg
Comment 6 2017-08-09 15:07:07 PDT
Created attachment 317751 [details] Patch
mitz
Comment 7 2017-08-10 08:14:09 PDT
Comment on attachment 317751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317751&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm:48 > + RetainPtr<WKPreferences> b = adoptNS([a.get() copy]); Is it necessary to write .get() here?
Blaze Burg
Comment 8 2017-08-10 12:50:26 PDT
Comment on attachment 317751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317751&action=review >> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm:48 >> + RetainPtr<WKPreferences> b = adoptNS([a.get() copy]); > > Is it necessary to write .get() here? Apparently not! I forgot about that cast operator. Fixed it.
Blaze Burg
Comment 9 2017-08-10 12:51:13 PDT
Created attachment 317836 [details] For Landing
WebKit Commit Bot
Comment 10 2017-08-10 13:34:43 PDT
Comment on attachment 317836 [details] For Landing Clearing flags on attachment: 317836 Committed r220542: <http://trac.webkit.org/changeset/220542>
WebKit Commit Bot
Comment 11 2017-08-10 13:34:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.