| Summary: | Update sendBeacon() to rely on FetchBody instead of the whole FetchRequest | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, rniwa, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| URL: | https://w3c.github.io/beacon/#sec-processing-model | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 175264 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Chris Dumez
2017-08-07 13:00:50 PDT
Created attachment 317454 [details]
Patch
Comment on attachment 317454 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317454&action=review > Source/WebCore/ChangeLog:9 > + for data destruction is really the only thing we need at the moment. data extraction? > Source/WebCore/Modules/beacon/NavigatorBeacon.cpp:35 > #include <runtime/JSCJSValue.h> Do you still need that include? > Source/WebCore/Modules/beacon/NavigatorBeacon.cpp:64 > + options.redirect = FetchOptions::Redirect::Follow; No need to set redirect to follow, this is the default and is not spelled out in the spec explicitly. > Source/WebCore/Modules/beacon/NavigatorBeacon.cpp:65 > + options.cache = FetchOptions::Cache::NoCache; I do not see that option set in the spec. I forgot to ask why it was set in previous patches. Created attachment 317463 [details]
Patch
Comment on attachment 317463 [details] Patch Attachment 317463 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4272222 New failing tests: http/tests/blink/sendbeacon/beacon-same-origin.html Created attachment 317480 [details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 317482 [details]
Patch
Comment on attachment 317482 [details] Patch Clearing flags on attachment: 317482 Committed r220366: <http://trac.webkit.org/changeset/220366> All reviewed patches have been landed. Closing bug. |