| Summary: | Web Inspector: create better icon for Canvas Path navigation item | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||||
| Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | agomez, buildbot, commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 175485, 178432 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Devin Rousso
2017-08-07 11:23:15 PDT
Created attachment 318413 [details]
Patch
Created attachment 318414 [details]
[Image] Show path button
I like using the arc, it better conveys "path" than a straight line IMO.
Created attachment 318453 [details]
Patch
Created attachment 318454 [details]
[Image] Show path button - final
Changes based on feedback.
Comment on attachment 318453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318453&action=review Please file a bug for Images/gtk. You may want to copy the PaintFlashing icon as Path.svg for gtk until they have a replacement. It would be bad to have a missing box icon. > Source/WebInspectorUI/UserInterface/Images/Path.svg:6 > + <path stroke="currentColor" fill="none" d="M 3 12 S 3 2 8 8 c 5.44 6.52 5-4 5-4"/> This syntax is a little weird to me. I think the lowercase 'c' is important (relative curve). The "5-4" is this actually "5 -4"? If so a space might be helpful just for readability. Created attachment 318458 [details]
Patch
Comment on attachment 318458 [details] Patch Clearing flags on attachment: 318458 Committed r220898: <http://trac.webkit.org/changeset/220898> All reviewed patches have been landed. Closing bug. |