Bug 175268

Summary: [GLib] Standardize naming scheme of GLib-specific files
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: NEW    
Severity: Normal CC: bugs-noreply, cgarcia, mcatanzaro
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Michael Catanzaro
Reported 2017-08-07 10:11:58 PDT
We need a standard naming scheme for GLib-specific files. Currently our files do not agree on whether to capitalize the L in GLib. E.g. we have RunLoopGLib.cpp but KeyedEncoderGlib.cpp. Personally, I prefer GLib with a capitalized L, since we normally capitalize letters in WebKit variable names when appropriate.
Attachments
Patch (237.97 KB, patch)
2017-08-07 12:53 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (239.32 KB, patch)
2017-08-07 13:08 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (240.38 KB, patch)
2017-08-07 14:27 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-08-07 12:53:27 PDT
Created attachment 317453 [details] Patch
Michael Catanzaro
Comment 2 2017-08-07 12:53:59 PDT
This was probably a complete and total waste of time, but now that I'd noticed it was going to start really annoying me. :)
Michael Catanzaro
Comment 3 2017-08-07 13:08:18 PDT
Created attachment 317455 [details] Patch
Michael Catanzaro
Comment 4 2017-08-07 14:27:21 PDT
Created attachment 317466 [details] Patch
Michael Catanzaro
Comment 5 2017-08-07 17:55:26 PDT
Well enough EWS are red with a linker error that I presume it's really broken, but it builds fine locally, so that's odd.
Carlos Garcia Campos
Comment 6 2017-08-07 22:32:29 PDT
I'm not sure it's worth breaking history files (git log/blame) only because of this to be honest. I know we can use -M -C in git blame, which makes it slower. It's already a pain to track history of files with git log after several renames / -> Source, WebKit2 -> WebKit
Michael Catanzaro
Comment 7 2017-08-08 05:47:03 PDT
It's not really at all significant after the WebKit2 -> WebKit rename. But I don't want to debug why this is broken on EWS, so this won't go anywhere. :)
Note You need to log in before you can comment on or make changes to this bug.