Summary: | Web Automation: setUserInputForCurrentJavaScriptPrompt should fail if current dialog is not a prompt | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bburg, berto, buildbot, gustavo, joepeck, mcatanzaro, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 175259 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2017-08-07 04:11:02 PDT
This causes test testSettingTheValueOfAnAlertThrows to fail: _______________________________________________________________________ testSettingTheValueOfAnAlertThrows[WebKitGTK] ________________________________________________________________________ driver = <selenium.webdriver.webkitgtk.webdriver.WebDriver (session="9ba3f06c-5437-4548-93de-bd4eb5c12f15")>, pages = <conftest.Pages object at 0x7f4785758950> @pytest.mark.xfail_chrome( reason='https://bugs.chromium.org/p/chromedriver/issues/detail?id=1353') @pytest.mark.xfail_phantomjs( reason='https://github.com/detro/ghostdriver/issues/20', raises=WebDriverException) def testSettingTheValueOfAnAlertThrows(driver, pages): pages.load("alerts.html") driver.find_element(By.ID, "alert").click() alert = _waitForAlert(driver) with pytest.raises(InvalidElementStateException): > alert.send_keys("cheese") E Failed: DID NOT RAISE <class 'selenium.common.exceptions.InvalidElementStateException'> Created attachment 317411 [details]
Patch
Comment on attachment 317411 [details]
Patch
r=me if it builds. Please upload rebased patch.
Created attachment 317546 [details]
Patch for landing
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Created attachment 317548 [details]
Patch for landing
Committed r220394: <http://trac.webkit.org/changeset/220394> |