Bug 175261 – Web Automation: setUserInputForCurrentJavaScriptPrompt should fail if current dialog is not a prompt

• Component: WebKit2
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

https://w3c.github.io/webdriver/webdriver-spec.html#send-alert-text

[Carlos Garcia Campos]

This causes test testSettingTheValueOfAnAlertThrows to fail:

_______________________________________________________________________ testSettingTheValueOfAnAlertThrows[WebKitGTK] ________________________________________________________________________

driver = <selenium.webdriver.webkitgtk.webdriver.WebDriver (session="9ba3f06c-5437-4548-93de-bd4eb5c12f15")>, pages = <conftest.Pages object at 0x7f4785758950>

    @pytest.mark.xfail_chrome(
        reason='https://bugs.chromium.org/p/chromedriver/issues/detail?id=1353')
    @pytest.mark.xfail_phantomjs(
        reason='https://github.com/detro/ghostdriver/issues/20',
        raises=WebDriverException)
    def testSettingTheValueOfAnAlertThrows(driver, pages):
        pages.load("alerts.html")
        driver.find_element(By.ID, "alert").click()
    
        alert = _waitForAlert(driver)
        with pytest.raises(InvalidElementStateException):
>           alert.send_keys("cheese")
E           Failed: DID NOT RAISE <class 'selenium.common.exceptions.InvalidElementStateException'>

[Carlos Garcia Campos]

Created attachment 317411 [details]
Patch

[Blaze Burg]

Comment on attachment 317411 [details]
Patch

r=me if it builds. Please upload rebased patch.

[Radar WebKit Bug Importer]

<rdar://problem/33770078>

[Carlos Garcia Campos]

Created attachment 317546 [details]
Patch for landing

[Build Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

Created attachment 317548 [details]
Patch for landing

[Carlos Garcia Campos]

Committed r220394: <http://trac.webkit.org/changeset/220394>