Bug 175260

Summary: [JSC] Use reifying system for "name" property of builtin JSFunction
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, buildbot, fpizlo, ggaren, jfbastien, keith_miller, mark.lam, msaboff, ryanhaddad, saam, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
Patch saam: review+

Yusuke Suzuki
Reported 2017-08-07 03:33:13 PDT
[JSC] Use reifying system for "name" property of builtin JSFunction
Attachments
Patch (108.07 KB, patch)
2017-08-07 03:51 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (116.22 KB, patch)
2017-08-07 04:48 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (116.42 KB, patch)
2017-08-07 07:02 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (943.00 KB, application/zip)
2017-08-07 10:57 PDT, Build Bot 		no flags
Details
Patch (116.58 KB, patch)
2017-08-08 05:15 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-08-07 03:51:49 PDT
Created attachment 317410 [details] Patch
Build Bot
Comment 2 2017-08-07 03:53:01 PDT
This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)
Yusuke Suzuki
Comment 3 2017-08-07 04:48:51 PDT
Created attachment 317415 [details] Patch
Yusuke Suzuki
Comment 4 2017-08-07 07:02:38 PDT
Created attachment 317418 [details] Patch
Build Bot
Comment 5 2017-08-07 10:57:30 PDT
Comment on attachment 317418 [details] Patch Attachment 317418 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4270653 New failing tests: js/dom/builtin-getter-name.html
Build Bot
Comment 6 2017-08-07 10:57:31 PDT
Created attachment 317439 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Yusuke Suzuki
Comment 7 2017-08-08 05:15:54 PDT
Created attachment 317560 [details] Patch
Saam Barati
Comment 8 2017-08-29 14:37:54 PDT
Comment on attachment 317560 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317560&action=review r=me > Source/JavaScriptCore/ChangeLog:10 > + to apply this reifying mechanism to builtin JSFunction to simply code and drop simply => simplify
Yusuke Suzuki
Comment 9 2017-08-29 16:54:23 PDT
Comment on attachment 317560 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317560&action=review >> Source/JavaScriptCore/ChangeLog:10 >> + to apply this reifying mechanism to builtin JSFunction to simply code and drop > > simply => simplify Thanks, fixed.
Yusuke Suzuki
Comment 10 2017-08-29 17:06:50 PDT
Committed r221327: <http://trac.webkit.org/changeset/221327>
Radar WebKit Bug Importer
Comment 11 2017-08-29 17:08:17 PDT
<rdar://problem/34147418>
Ryan Haddad
Comment 12 2017-08-30 09:13:16 PDT
(In reply to Yusuke Suzuki from comment #10) > Committed r221327: <http://trac.webkit.org/changeset/221327> This change caused 8 failures on test262: https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20Test262%20%28Tests%29/builds/3724
Ryan Haddad
Comment 13 2017-08-30 15:54:27 PDT
Reverted r221327 for reason: This change caused test262 failures. Committed r221404: <http://trac.webkit.org/changeset/221404>
Yusuke Suzuki
Comment 14 2017-08-31 03:04:55 PDT
Committed r221417: <http://trac.webkit.org/changeset/221417>
Note You need to log in before you can comment on or make changes to this bug.