Bug 175236

Summary: Update font selection algorithm to match latest CSS spec
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, darin, dino, jonlee, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Needs tests
none
WIP
none
Patch
none
Patch none

Myles C. Maxfield
Reported 2017-08-04 23:16:09 PDT
Update font selection algorithm to match latest CSS spec
Attachments
Needs tests (4.85 KB, patch)
2017-08-04 23:17 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (32.25 KB, patch)
2017-08-06 06:54 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (34.25 KB, patch)
2017-08-08 19:03 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (35.21 KB, patch)
2017-08-09 08:05 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2017-08-04 23:17:35 PDT
Created attachment 317330 [details] Needs tests
Myles C. Maxfield
Comment 2 2017-08-06 06:54:16 PDT
Created attachment 317361 [details] WIP
Myles C. Maxfield
Comment 3 2017-08-08 19:03:58 PDT
Created attachment 317664 [details] Patch
Build Bot
Comment 4 2017-08-08 19:05:01 PDT
Attachment 317664 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:10: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Myles C. Maxfield
Comment 5 2017-08-09 08:05:39 PDT
Created attachment 317701 [details] Patch
Darin Adler
Comment 6 2017-09-03 23:35:48 PDT
Comment on attachment 317701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317701&action=review > Source/WebCore/platform/graphics/FontSelectionAlgorithm.h:220 > +static inline FontSelectionValue lowerWeightSearchThreshold() All these functions that return FontSelectionValue could instead return const FontSelectionValue&. Unclear to me how OK it is that they copy every time they are called. > LayoutTests/ChangeLog:9 > + * fast/text/variations/font-selection-font-weight-expected.html: Added. > + * fast/text/variations/font-selection-font-weight.html: Added. Note that reference tests only compare the top 800x600; is this test fitting or spilling off the bottom?
Myles C. Maxfield
Comment 7 2017-09-05 12:28:23 PDT
Comment on attachment 317701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317701&action=review >> Source/WebCore/platform/graphics/FontSelectionAlgorithm.h:220 >> +static inline FontSelectionValue lowerWeightSearchThreshold() > > All these functions that return FontSelectionValue could instead return const FontSelectionValue&. Unclear to me how OK it is that they copy every time they are called. A FontSelectionValue is 2 bytes, so it is a better choice than a reference. >> LayoutTests/ChangeLog:9 >> + * fast/text/variations/font-selection-font-weight.html: Added. > > Note that reference tests only compare the top 800x600; is this test fitting or spilling off the bottom? It fits because all the frames are 48x48 and are inline-blocks.
WebKit Commit Bot
Comment 8 2017-09-05 12:57:12 PDT
Comment on attachment 317701 [details] Patch Clearing flags on attachment: 317701 Committed r221630: <http://trac.webkit.org/changeset/221630>
WebKit Commit Bot
Comment 9 2017-09-05 12:57:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-09-27 12:54:49 PDT
<rdar://problem/34694258>
Note You need to log in before you can comment on or make changes to this bug.