Bug 175203

Summary:

[WebGL2] Implement getActiveUniforms()

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

WebGL

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, cdumez, darin, dino, esprehn+autocc, graouts, gyuyoung.kim, kondapallykalyan, mcatanzaro, noam, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=176444

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
WIP patch	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	none
Patch for landing	none

Zan Dobersek

Reported 2017-08-04 13:04:51 PDT

[WebGL2] Implement getActiveUniforms()

Attachments
Patch (13.13 KB, patch) 2017-08-04 13:09 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.18 MB, application/zip) 2017-08-04 13:59 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.07 MB, application/zip) 2017-08-04 14:25 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.76 MB, application/zip) 2017-08-04 14:44 PDT, Build Bot	no flags	Details
WIP patch (13.13 KB, patch) 2017-08-08 12:02 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.26 MB, application/zip) 2017-08-08 13:12 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews100 for mac-elcapitan (1.07 MB, application/zip) 2017-08-08 13:16 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.97 MB, application/zip) 2017-08-08 13:48 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (7.09 MB, application/zip) 2017-08-08 13:58 PDT, Build Bot	no flags	Details
Patch (14.87 KB, patch) 2017-08-23 10:51 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch for landing (14.97 KB, patch) 2017-09-06 00:04 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Zan Dobersek

Comment 1 2017-08-04 13:06:55 PDT

Minimum required to get the demo at http://get.webgl.org/webgl2 working.

Zan Dobersek

Comment 2 2017-08-04 13:09:53 PDT

Created attachment 317272 [details] Patch

Build Bot

Comment 3 2017-08-04 13:59:22 PDT

Comment on attachment 317272 [details] Patch Attachment 317272 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4254835 New failing tests: fast/canvas/webgl/webgl2-getActiveUniforms.html

Build Bot

Comment 4 2017-08-04 13:59:23 PDT

Created attachment 317279 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-08-04 14:25:14 PDT

Comment on attachment 317272 [details] Patch Attachment 317272 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4254943 New failing tests: fast/canvas/webgl/webgl2-getActiveUniforms.html

Build Bot

Comment 6 2017-08-04 14:25:16 PDT

Created attachment 317287 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-08-04 14:44:00 PDT

Comment on attachment 317272 [details] Patch Attachment 317272 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4254985 New failing tests: fast/canvas/webgl/webgl2-getActiveUniforms.html

Build Bot

Comment 8 2017-08-04 14:44:01 PDT

Created attachment 317293 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Zan Dobersek

Comment 9 2017-08-08 12:02:38 PDT

Created attachment 317592 [details] WIP patch Poking iOS EWSs to see if they run tests ...

Build Bot

Comment 10 2017-08-08 13:12:19 PDT

Comment on attachment 317592 [details] WIP patch Attachment 317592 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4279402 New failing tests: fast/canvas/webgl/webgl2-getActiveUniforms.html

Build Bot

Comment 11 2017-08-08 13:12:20 PDT

Created attachment 317601 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 12 2017-08-08 13:16:21 PDT

Comment on attachment 317592 [details] WIP patch Attachment 317592 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4279423 New failing tests: fast/canvas/webgl/webgl2-getActiveUniforms.html

Build Bot

Comment 13 2017-08-08 13:16:23 PDT

Created attachment 317603 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 14 2017-08-08 13:48:34 PDT

Comment on attachment 317592 [details] WIP patch Attachment 317592 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4279482 New failing tests: fast/canvas/webgl/webgl2-getActiveUniforms.html

Build Bot

Comment 15 2017-08-08 13:48:36 PDT

Created attachment 317608 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 16 2017-08-08 13:58:54 PDT

Comment on attachment 317592 [details] WIP patch Attachment 317592 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4279493 New failing tests: fast/canvas/webgl/webgl2-getActiveUniforms.html

Build Bot

Comment 17 2017-08-08 13:58:56 PDT

Created attachment 317609 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Zan Dobersek

Comment 18 2017-08-23 10:51:28 PDT

Created attachment 318885 [details] Patch

Darin Adler

Comment 19 2017-09-04 00:04:10 PDT

Comment on attachment 318885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318885&action=review > LayoutTests/platform/mac/TestExpectations:1627 > +webkit.org/b/175203 fast/canvas/webgl/webgl2-getActiveUniforms.html [ Failure ] Bug number doesn’t make sense here. It’s this bug! But it should be the bug about not being able to compile the shader properly?

Michael Catanzaro

Comment 20 2017-09-04 08:32:20 PDT

Yes Zan, you know that the bug number in our expectations needs to point to a bug that will be open after the patch lands. ;)

Zan Dobersek

Comment 21 2017-09-05 23:58:34 PDT

(In reply to Darin Adler from comment #19) > Comment on attachment 318885 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318885&action=review > > > LayoutTests/platform/mac/TestExpectations:1627 > > +webkit.org/b/175203 fast/canvas/webgl/webgl2-getActiveUniforms.html [ Failure ] > > Bug number doesn’t make sense here. It’s this bug! But it should be the bug > about not being able to compile the shader properly? Opened bug #176444 for this failure.

Zan Dobersek

Comment 22 2017-09-06 00:04:53 PDT

Created attachment 319990 [details] Patch for landing

Zan Dobersek

Comment 23 2017-09-06 01:18:02 PDT

Comment on attachment 319990 [details] Patch for landing Clearing flags on attachment: 319990 Committed r221667: <http://trac.webkit.org/changeset/221667>

Zan Dobersek

Comment 24 2017-09-06 01:18:07 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 25 2017-09-27 12:51:52 PDT

<rdar://problem/34694165>

Note You need to log in before you can comment on or make changes to this bug.