Bug 175165

Summary:

Remove STREAM_API compilation guard

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

REOPENED

Severity:

Normal

CC:

benjamin, buildbot, cdumez, cmarcelo, commit-queue, darin, dbates, esprehn+autocc, jlewis3, keith_miller, kondapallykalyan, mark.lam, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

youenn fablet

Reported 2017-08-03 16:43:22 PDT

No longer needed

Attachments
Patch (86.06 KB, patch) 2017-08-03 17:05 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (85.39 KB, patch) 2017-08-03 21:55 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-08-03 17:05:10 PDT

Created attachment 317183 [details] Patch

WebKit Commit Bot

Comment 2 2017-08-03 21:46:21 PDT

Comment on attachment 317183 [details] Patch Rejecting attachment 317183 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 317183, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: eferences.mm patching file Source/WebKitLegacy/mac/WebView/WebView.mm patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig Hunk #2 FAILED at 242. 1 out of 2 hunks FAILED -- saving rejects to file Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/4250652

youenn fablet

Comment 3 2017-08-03 21:55:48 PDT

Created attachment 317212 [details] Patch for landing

WebKit Commit Bot

Comment 4 2017-08-04 08:20:39 PDT

Comment on attachment 317212 [details] Patch for landing Clearing flags on attachment: 317212 Committed r220271: <http://trac.webkit.org/changeset/220271>

WebKit Commit Bot

Comment 5 2017-08-04 08:20:40 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2017-08-04 08:22:03 PDT

<rdar://problem/33724934>

Matt Lewis

Comment 7 2017-08-04 11:28:28 PDT

Reverted r220271 for reason: Rolling out due to Layout Test failing on iOS Simulator. Committed r220279: <http://trac.webkit.org/changeset/220279>

Note You need to log in before you can comment on or make changes to this bug.