Bug 175142

Summary: Rename ScratchBuffer::activeLengthPtr to addressOfActiveLength.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, fpizlo, keith_miller, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. none

Mark Lam
Reported 2017-08-03 11:25:14 PDT
The convention in the rest of of JSC for such methods which return the address of a field is to name them "addressOf<field name>". We'll rename ScratchBuffer::activeLengthPtr to be consistent with this convention.
Attachments
proposed patch. (13.87 KB, patch)
2017-08-03 11:31 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-08-03 11:26:30 PDT
<rdar://problem/33704528>
Mark Lam
Comment 2 2017-08-03 11:31:48 PDT
Created attachment 317132 [details] proposed patch.
Mark Lam
Comment 3 2017-08-03 11:37:34 PDT
Comment on attachment 317132 [details] proposed patch. Thanks for the review.
WebKit Commit Bot
Comment 4 2017-08-03 12:17:17 PDT
Comment on attachment 317132 [details] proposed patch. Clearing flags on attachment: 317132 Committed r220219: <http://trac.webkit.org/changeset/220219>
WebKit Commit Bot
Comment 5 2017-08-03 12:17:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.