Bug 175098 – REGRESSION (r207155): Unable to switch sheets when previewing Numbers '09 spreadsheets

• Component: New Bugs
• Status: RESOLVED FIXED

[Andy Estes]

REGRESSION (r207155): Unable to switch sheets when previewing Numbers '09 spreadsheets

[Andy Estes]

rdar://problem/31416763

[Andy Estes]

Created attachment 317024 [details]
Patch

[Daniel Bates]

Comment on attachment 317024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317024&action=review

> Source/WebCore/ChangeLog:17
> +        sandbox will be able to navigate eachother, but will not be able to navigate the top frame

eachother => each other

[Andy Estes]

Created attachment 317029 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 317029 [details]
Patch

Clearing flags on attachment: 317029

Committed r220163: <http://trac.webkit.org/changeset/220163>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 317024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317024&action=review

> Source/WebCore/dom/SecurityContext.h:101
> +    // It's only appropriate to call this during security context initialization; it's needed for
> +    // flags that can't be disabled with allow-* attributes, such as SandboxNavigation.
> +    void disableSandboxFlags(SandboxFlags mask) { m_sandboxFlags &= ~mask; }

Would be nice to define what "during initialization" means; I’m unclear when that ends.

[Andy Estes]

(In reply to Darin Adler from comment #7)
> Comment on attachment 317024 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=317024&action=review
> 
> > Source/WebCore/dom/SecurityContext.h:101
> > +    // It's only appropriate to call this during security context initialization; it's needed for
> > +    // flags that can't be disabled with allow-* attributes, such as SandboxNavigation.
> > +    void disableSandboxFlags(SandboxFlags mask) { m_sandboxFlags &= ~mask; }
> 
> Would be nice to define what "during initialization" means; I’m unclear when
> that ends.

I meant during construction of a subclass of SecurityContext. My concern was that enabling some flags have side effects that can't easily be undone after the SecurityContext is created; e.g. enabling SandboxOrigin changes the security origin policy.

[Darin Adler]

(In reply to Andy Estes from comment #8)
> (In reply to Darin Adler from comment #7)
> > > Source/WebCore/dom/SecurityContext.h:101
> > > +    // It's only appropriate to call this during security context initialization; it's needed for
> > > +    // flags that can't be disabled with allow-* attributes, such as SandboxNavigation.
> > > +    void disableSandboxFlags(SandboxFlags mask) { m_sandboxFlags &= ~mask; }
> > 
> > Would be nice to define what "during initialization" means; I’m unclear when
> > that ends.
> 
> I meant during construction of a subclass of SecurityContext.

OK, that makes total sense to me. I think we should tighten up the terminology in the comment.