Bug 17505

Summary: Add support for getting command line arguments in testkjs
Product: WebKit Reporter: Sam Weinig <sam>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
work in progress
none
patch
oliver: review+
updated patch
none
updated without build issues mrowe: review+

Sam Weinig
Reported 2008-02-23 22:14:30 PST
The SpiderMonkey js shell supports passing command line arguments to the scripts being executed by way of a global 'arguments' variable.
Attachments
work in progress (3.07 KB, patch)
2008-02-23 22:23 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
patch (4.18 KB, patch)
2008-02-24 14:59 PST, Sam Weinig 		oliver: review+
DetailsFormatted DiffDiff
updated patch (4.59 KB, patch)
2008-02-24 17:24 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
updated without build issues (4.58 KB, patch)
2008-02-24 17:25 PST, Sam Weinig 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2008-02-23 22:23:09 PST
Created attachment 19310 [details] work in progress
Sam Weinig
Comment 2 2008-02-24 14:59:58 PST
Created attachment 19328 [details] patch
Brent Fulgham
Comment 3 2008-02-24 16:18:23 PST
This definitely works well, and allowed generation of performance data for http://shootout.alioth.debian.org
Oliver Hunt
Comment 4 2008-02-24 16:46:56 PST
Comment on attachment 19328 [details] patch r=me, provided you ensure run-javscriptcore-tests and run-sunspider still work correctly
Sam Weinig
Comment 5 2008-02-24 17:24:09 PST
Created attachment 19330 [details] updated patch
Sam Weinig
Comment 6 2008-02-24 17:25:56 PST
Created attachment 19331 [details] updated without build issues
Mark Rowe (bdash)
Comment 7 2008-02-24 17:37:34 PST
Comment on attachment 19331 [details] updated without build issues r=me
Sam Weinig
Comment 8 2008-02-24 17:37:54 PST
Landed in r30553.
Note You need to log in before you can comment on or make changes to this bug.