Bug 17504

Summary:

Speed up DOM lists array subscription syntax by using the fast getOwnPropertySlot and set paths

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

WebCore JavaScript

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	oliver: review+

Sam Weinig

Reported 2008-02-23 17:20:36 PST

We are needlessly converting from unsigned -> Identifier -> unsigned when doing indexGetting and setting for DOM lists like the NodeList or the new CanvasPixelArray. We can speed it up by using the fast getOwnPropertySlot and put methods that take an unsigned. This technique is already employed by ArrayInstance.

Attachments
patch (5.67 KB, patch) 2008-02-23 17:32 PST, Sam Weinig	oliver: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2008-02-23 17:32:20 PST

Created attachment 19308 [details] patch This speeds Oliver's CanvasPixelArray test up by 6x.

Sam Weinig

Comment 2 2008-02-23 17:37:05 PST

Landed in r30529.

Note You need to log in before you can comment on or make changes to this bug.