Bug 17503

Summary:

WebFrame should not implement FrameLoaderClient

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

WebKit Misc.

Assignee:

Adam Roben (:aroben) <aroben>

Status:

NEW

Severity:

Minor

CC:

andersca, ap

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Move two more methods	none
Move many dispatch methods	none
remove an unused method	none
Move progress-related methods	none
Move createFrame	none
Move plugin-related methods	none
Move cache-related methods	none
Move WebHistory-related methods	none
Get rid of IID_WebFrame	none
Move two more methods	none
Move ResourceLoadDelegate methods	none
WIP patch to move PolicyDelegate-related methods	none

Adam Roben (:aroben)

Reported 2008-02-23 12:37:02 PST

On Windows, WebFrame implements FrameLoaderClient. This bloats the WebFrame class, and doesn't match all the other platforms, which all have a separate class that implements FrameLoaderClient. We should switch Windows to match the other platforms.

Attachments
Move two more methods (3.88 KB, patch) 2008-02-23 12:38 PST, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
Move many dispatch methods (14.98 KB, patch) 2008-02-23 12:41 PST, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
remove an unused method (1.97 KB, patch) 2008-02-25 15:08 PST, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
Move progress-related methods (6.92 KB, patch) 2008-02-25 15:16 PST, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
Move createFrame (13.97 KB, patch) 2008-02-25 15:37 PST, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
Move plugin-related methods (22.53 KB, patch) 2008-02-25 15:56 PST, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
Move cache-related methods (10.25 KB, patch) 2008-02-26 09:19 PST, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
Move WebHistory-related methods (9.73 KB, patch) 2008-02-26 09:19 PST, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
Get rid of IID_WebFrame (3.60 KB, patch) 2008-02-26 09:19 PST, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
Move two more methods (8.71 KB, patch) 2008-02-26 09:19 PST, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
Move ResourceLoadDelegate methods (18.24 KB, patch) 2008-02-26 09:20 PST, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
WIP patch to move PolicyDelegate-related methods (20.23 KB, patch) 2008-02-26 16:54 PST, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2008-02-23 12:38:12 PST

Created attachment 19304 [details] Move two more methods More methods will come, but I'd like to get them reviewed and landed in small chunks.

Adam Roben (:aroben)

Comment 2 2008-02-23 12:41:46 PST

Created attachment 19306 [details] Move many dispatch methods

Adam Roben (:aroben)

Comment 3 2008-02-25 15:08:13 PST

Created attachment 19357 [details] remove an unused method

Adam Roben (:aroben)

Comment 4 2008-02-25 15:08:29 PST

Comment on attachment 19304 [details] Move two more methods Clearing review flag since this has been landed.

Adam Roben (:aroben)

Comment 5 2008-02-25 15:08:36 PST

Comment on attachment 19306 [details] Move many dispatch methods Clearing review flag since this has been landed.

Anders Carlsson

Comment 6 2008-02-25 15:13:18 PST

Comment on attachment 19357 [details] remove an unused method r=me

Adam Roben (:aroben)

Comment 7 2008-02-25 15:16:36 PST

Created attachment 19358 [details] Move progress-related methods

Anders Carlsson

Comment 8 2008-02-25 15:23:04 PST

Comment on attachment 19358 [details] Move progress-related methods r=me

Adam Roben (:aroben)

Comment 9 2008-02-25 15:37:29 PST

Created attachment 19360 [details] Move createFrame

Anders Carlsson

Comment 10 2008-02-25 15:42:04 PST

Comment on attachment 19360 [details] Move createFrame r=me

Adam Roben (:aroben)

Comment 11 2008-02-25 15:56:26 PST

Created attachment 19361 [details] Move plugin-related methods

Anders Carlsson

Comment 12 2008-02-25 16:01:46 PST

Comment on attachment 19361 [details] Move plugin-related methods r=me

Adam Roben (:aroben)

Comment 13 2008-02-25 17:01:31 PST

Comment on attachment 19357 [details] remove an unused method Landed as r30579

Adam Roben (:aroben)

Comment 14 2008-02-25 17:04:50 PST

Comment on attachment 19358 [details] Move progress-related methods Landed as r30580

Adam Roben (:aroben)

Comment 15 2008-02-25 17:05:25 PST

Comment on attachment 19360 [details] Move createFrame Landed as r30581

Adam Roben (:aroben)

Comment 16 2008-02-25 17:05:50 PST

Comment on attachment 19361 [details] Move plugin-related methods Landed as r30582

Adam Roben (:aroben)

Comment 17 2008-02-26 09:19:15 PST

Created attachment 19376 [details] Move cache-related methods

Adam Roben (:aroben)

Comment 18 2008-02-26 09:19:28 PST

Created attachment 19377 [details] Move WebHistory-related methods

Adam Roben (:aroben)

Comment 19 2008-02-26 09:19:43 PST

Created attachment 19378 [details] Get rid of IID_WebFrame

Adam Roben (:aroben)

Comment 20 2008-02-26 09:19:56 PST

Created attachment 19379 [details] Move two more methods

Adam Roben (:aroben)

Comment 21 2008-02-26 09:20:12 PST

Created attachment 19380 [details] Move ResourceLoadDelegate methods

Anders Carlsson

Comment 22 2008-02-26 09:47:54 PST

Comment on attachment 19376 [details] Move cache-related methods r=me

Anders Carlsson

Comment 23 2008-02-26 09:48:37 PST

Comment on attachment 19377 [details] Move WebHistory-related methods r=me

Anders Carlsson

Comment 24 2008-02-26 09:51:00 PST

Comment on attachment 19378 [details] Get rid of IID_WebFrame r=me

Anders Carlsson

Comment 25 2008-02-26 09:51:38 PST

Comment on attachment 19379 [details] Move two more methods r=me

Anders Carlsson

Comment 26 2008-02-26 09:52:14 PST

Comment on attachment 19380 [details] Move ResourceLoadDelegate methods r=me

Adam Roben (:aroben)

Comment 27 2008-02-26 16:49:20 PST

Comment on attachment 19376 [details] Move cache-related methods Landed as r30608

Adam Roben (:aroben)

Comment 28 2008-02-26 16:49:59 PST

Comment on attachment 19377 [details] Move WebHistory-related methods Landed as r30609

Adam Roben (:aroben)

Comment 29 2008-02-26 16:50:26 PST

Comment on attachment 19378 [details] Get rid of IID_WebFrame Landed as r30610

Adam Roben (:aroben)

Comment 30 2008-02-26 16:50:51 PST

Comment on attachment 19379 [details] Move two more methods Landed as r30611

Adam Roben (:aroben)

Comment 31 2008-02-26 16:51:21 PST

Comment on attachment 19380 [details] Move ResourceLoadDelegate methods Landed as r30612

Adam Roben (:aroben)

Comment 32 2008-02-26 16:54:50 PST

Created attachment 19389 [details] WIP patch to move PolicyDelegate-related methods Here's a patch that moves the PolicyDelegate-related methods to WebFrameLoaderClient. Everything looks fine, but for some reason when the ResourceRequest gets passed from FrameLoader::checkNavigationPolicy to WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction, the const ResourceRequest& parameter becomes garbage and we crash.

Alexey Proskuryakov

Comment 33 2010-06-11 17:25:52 PDT

Adam, is this bug report still actionable?

Note You need to log in before you can comment on or make changes to this bug.