| Summary: | REGRESSION (r220052): http/tests/media/video-play-stall.html times out | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | Page Loading | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, beidson, commit-queue, darin, eric.carlson, jlewis3, kling, koivisto, sam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar, LayoutTestFailure, Regression | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=130653 | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Proskuryakov
2017-07-31 13:16:21 PDT
Should be easy to fix. I fixed lots of other bugs like this one. It would be good to skip this test to make the bots green. I promise I will re-enable it when I fix it. Skipped in: https://trac.webkit.org/changeset/220075/webkitx (In reply to Matt Lewis from comment #3) > Skipped in: > https://trac.webkit.org/changeset/220075/webkitx typo https://trac.webkit.org/changeset/220075/webkit Created attachment 316836 [details]
Patch
In fixing this bug I learned that it's very hard to get HTMLMediaElement to ever cancel a load once it's going. It even keeps loading when you switch src to load a different video. That is not a good thing, and worth investigating and fixing separately. It’s also not great that starting a load from inside a load event handler has any effect on the loading state at all. By the time the load event has been sent, it should be too late for new loads to have this kind of effect. We should make some other tests for that while making future fixes to the frame loading logic. I’d love to get this test re-enabled. Anyone willing to review? Comment on attachment 316836 [details] Patch Clearing flags on attachment: 316836 Committed r220098: <http://trac.webkit.org/changeset/220098> All reviewed patches have been landed. Closing bug. |