Bug 174988

Summary: REGRESSION (r220052): http/tests/media/video-play-stall.html times out
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Page LoadingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, commit-queue, darin, eric.carlson, jlewis3, kling, koivisto, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar, LayoutTestFailure, Regression
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=130653
Attachments:
Description Flags
Patch none

Alexey Proskuryakov
Reported 2017-07-31 13:16:21 PDT
http/tests/media/video-play-stall.html has started to time out every time on macOS Sierra and on Gtk after https://trac.webkit.org/r220052 (Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout). Happens with both WK1 and WK2. It passes on El Capitan, which is why EWS didn't catch this.
Attachments
Patch (2.19 KB, patch)
2017-07-31 23:10 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2017-07-31 13:22:34 PDT
Should be easy to fix. I fixed lots of other bugs like this one.
Darin Adler
Comment 2 2017-07-31 13:24:05 PDT
It would be good to skip this test to make the bots green. I promise I will re-enable it when I fix it.
Matt Lewis
Comment 3 2017-07-31 14:44:15 PDT
Skipped in: https://trac.webkit.org/changeset/220075/webkitx
Matt Lewis
Comment 4 2017-07-31 14:44:38 PDT
(In reply to Matt Lewis from comment #3) > Skipped in: > https://trac.webkit.org/changeset/220075/webkitx typo https://trac.webkit.org/changeset/220075/webkit
Darin Adler
Comment 5 2017-07-31 23:10:58 PDT
Created attachment 316836 [details] Patch
Darin Adler
Comment 6 2017-07-31 23:14:23 PDT
In fixing this bug I learned that it's very hard to get HTMLMediaElement to ever cancel a load once it's going. It even keeps loading when you switch src to load a different video. That is not a good thing, and worth investigating and fixing separately. It’s also not great that starting a load from inside a load event handler has any effect on the loading state at all. By the time the load event has been sent, it should be too late for new loads to have this kind of effect. We should make some other tests for that while making future fixes to the frame loading logic.
Darin Adler
Comment 7 2017-08-01 08:39:09 PDT
I’d love to get this test re-enabled. Anyone willing to review?
WebKit Commit Bot
Comment 8 2017-08-01 09:13:59 PDT
Comment on attachment 316836 [details] Patch Clearing flags on attachment: 316836 Committed r220098: <http://trac.webkit.org/changeset/220098>
WebKit Commit Bot
Comment 9 2017-08-01 09:14:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-08-01 09:15:02 PDT
<rdar://problem/33655124>
Note You need to log in before you can comment on or make changes to this bug.